Skip to content

Commit c8490fd

Browse files
NoamGaashclaude
andcommitted
Vendor the bus_times dependency so CI (and anyone else) can build
CI has failed on every push since it was added, including all of mine — I wrote both the workflow and the dependency and never checked the two were compatible. `uv sync` dies with: failed to fetch commit ... could not read Username for github.com because publictransporthackathon was a git+https dependency on noamf2001/PublicTransportHackathon, which is PRIVATE. It resolves in this devcontainer only because `gh auth login` has run here. GitHub Actions has no such credential, and neither does anyone who clones this public repo — so the project built on exactly one machine. Switches the dependency to a path dep on repos/PublicTransportHackathon and commits that source. .gitignore keeps ignoring repos/ generally (the yuvalko1 clone is reference material with its own upstream history) and un-ignores this one specifically, with the reason written down so the next person doesn't "tidy it up" and break the build again. The clone has no nested .git, so this vendors source rather than a repo-in-a-repo. Verified: `uv sync` resolves clean, `./dev check` registers 16 analyses. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent 40631df commit c8490fd

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

.gitignore

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,16 @@ frontend/.vite/
3131
.DS_Store
3232
Thumbs.db
3333

34-
# Teammates' repos, cloned for reference (./dev clone-repos). They're separate
35-
# git repos with their own history — vendoring them here would nest repos and
36-
# duplicate code we already pull in as a dependency.
34+
# Teammates' repos cloned for reference (./dev clone-repos) — read-only copies
35+
# with their own history upstream, not ours to carry.
3736
repos/
37+
# ...except PublicTransportHackathon, which is a real build dependency
38+
# (pyproject's publictransporthackathon points at it). It's a PRIVATE repo, so
39+
# a git+https dependency can't be fetched by CI or by anyone who clones this
40+
# public repo — vendoring the source is the only way the project builds
41+
# anywhere but this container. Upstream:
42+
# github.com/noamf2001/PublicTransportHackathon @ analyze-per-subsequent-stops
43+
!repos/PublicTransportHackathon/
3844

3945
# Cached Stride API responses (re-fetchable; keeps the API healthy)
4046
.cache/

0 commit comments

Comments
 (0)