-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Threshold (1-of-N) Support in HTS Precompile #1069
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3b7917b
to
cdef1c5
Compare
Hello everyone, Thank you all once again for your contributions thus far. Looking forward to our continuous collaboration on this. Cheers! |
Hi @mgarbs , it seems to me we solved all the pending issues. From my PoV we can proceed. |
From a technical point of view, I do not think this can be accommodated without system contract versioning as you would be potentially breaking existing contracts because of the need to redefine the |
I totally agree with @lukelee-sl, this is a great candidate for the contract versioning initiative. |
I agree that this is a good fit for the new contract versioning initiative. @lukelee-sl I don't think we need to make an explicit reference to this detail in the HIP, especially if the new process is going to be the new norm, but just in case, feel free to suggest some changes. @stoyanov-st Yes, we need to make as many details explicit as possible, but they can be just an example and the real struct can be defined later. The guidelines for a HIP are to make explicit any changes that affect the operation of the network, including interfaces. In this case, if we maintain compatibility with old contracts, as we will now do with the versioning system, we can more easily skip all the details on the Solidity side, but it's good to have them as an initial idea and as a reference for developers reading the HIPs in the future. If there are major changes during development, we can always update the HIP with the correct interfaces, but if there are major changes, we will need to do a new HIP release. |
Signed-off-by: Michael Garber <[email protected]>
556c886
to
2e4a81d
Compare
After carefully reviewing this HIP, the smart contracts team has agreed on several discussion topics that need to be addressed for the clarity and understanding of this feature. Those are:
Considering the impact that this proposal is going to make, we need to be careful and also be able to foresee most of the implications that it is going to produce. |
Enable Threshold Keys Support in HTS updateTokenKeys Precompile
This update adds support for using threshold keyswithin the
updateTokenKeys
HTS precompile function, allowing developers to set token keys with multiple signatories directly in smart contracts. While complex keys are supported in the SDK, this enhancement allows on-chain token management with multi-signature and threshold-controlled permissions, expanding flexibility for applications requiring decentralized control over token keys.