refactor: 💡 update logic to get preferred rdp client (#3066)

* refactor: 💡 updated logic to store preferred rdp client

* refactor: 💡 simplified preferred client logic

Author: priya-patel04

ui/desktop/electron-app/src/services/rdp-client-manager.js

@@ -78,30 +78,23 @@ class RdpClientManager {
   }
 
   /**
-   * Gets the best default RDP client (first available that's not 'none')
-   * @returns {Promise<string>} Best RDP client value or 'none'
+   * Gets the user's preferred RDP client, auto-detecting if not set
+   * @returns {Promise<string>} Preferred RDP client value
    */
-  async getBestDefaultRdpClient() {
+  async getPreferredRdpClient() {
     const availableClients = await this.getAvailableRdpClients();
-    const bestClient = availableClients.find(
+    const installedClients = availableClients.filter(
       (client) => client !== RDP_CLIENT_NONE,
     );
-    return bestClient ?? RDP_CLIENT_NONE;
-  }
 
-  /**
-   * Gets the user's preferred RDP client, auto-detecting if not set
-   * @returns {Promise<string>} Preferred RDP client value
-   */
-  async getPreferredRdpClient() {
-    let preferredClient = store.get('preferredRdpClient');
+    if (installedClients.length === 0) return RDP_CLIENT_NONE;
 
-    if (!preferredClient) {
-      // Auto-detect and set the best available client
-      preferredClient = await this.getBestDefaultRdpClient();
-      store.set('preferredRdpClient', preferredClient);
-    }
-    return preferredClient;
+    const preferredClient =
+      store.get('preferredRdpClient') ?? installedClients[0];
+    // check if preferred client is still installed
+    return installedClients.includes(preferredClient)
+      ? preferredClient
+      : RDP_CLIENT_NONE;
   }
 
   /**