chore: 🤖 pr feedback, tests

Author: DhariniJeeva

ui/admin/app/components/form/auth-method/oidc/index.hbs

@@ -257,7 +257,6 @@
     @disabled={{form.disabled}}
     @isOptional={{true}}
     @keyFieldType='text'
-    @showValueField={{true}}
     @valueFieldType='select'
     @valueFieldOptions={{this.toClaims}}
     @keyLabel={{t 'form.from_claim.label'}}

ui/admin/app/components/form/credential-library/vault-ssh-certificate/index.hbs

@@ -234,7 +234,6 @@
     @errors={{@model.errors.critical_options}}
     @disabled={{form.disabled}}
     @isOptional={{true}}
-    @showValueField={{true}}
     @keyFieldType='text'
     @valueFieldType='text'
   />

ui/admin/app/components/form/field/key-value/index.hbs

@@ -15,13 +15,6 @@
     {{#if @helperText}}
       <H.HelperText data-test-helper-text>{{@helperText}}</H.HelperText>
     {{/if}}
-    {{#if @errors}}
-      <H.Error data-test-error as |E|>
-        {{#each @errors as |error|}}
-          <E.Message data-test-error-message>{{error.message}}</E.Message>
-        {{/each}}
-      </H.Error>
-    {{/if}}
   </:header>
   <:row as |R|>
     <R.Field as |F|>
@@ -31,6 +24,7 @@
           name={{@name}}
           disabled={{@disabled}}
           data-test-key-input
+          @isInvalid={{@errors}}
           {{on 'change' (fn this.updateKey R.rowData)}}
         >
           <option disabled hidden selected value=''>
@@ -51,6 +45,7 @@
           @value={{R.rowData.key}}
           disabled={{@disabled}}
           data-test-key-input
+          @isInvalid={{@errors}}
           {{on 'input' (fn this.updateKey R.rowData)}}
         />
       {{else}}
@@ -60,19 +55,21 @@
           @value={{R.rowData.key}}
           disabled={{@disabled}}
           data-test-key-input
+          @isInvalid={{@errors}}
           {{on 'input' (fn this.updateKey R.rowData)}}
         />
       {{/if}}
     </R.Field>
 
-    {{#if this.showValueField}}
+    {{#unless this.hideValueField}}
       <R.Field as |F|>
         <F.Label>{{or @valueLabel (t 'form.value.label')}}</F.Label>
         {{#if (eq @valueFieldType 'select')}}
           <F.Select
             name={{@name}}
             disabled={{@disabled}}
             data-test-value-input
+            @isInvalid={{@errors}}
             {{on 'change' (fn this.updateValue R.rowData)}}
           >
             <option disabled hidden selected value=''>
@@ -89,9 +86,11 @@
           </F.Select>
         {{else if (eq @valueFieldType 'textarea')}}
           <F.Textarea
+            name={{@name}}
             @value={{R.rowData.value}}
             disabled={{@disabled}}
             data-test-value-input
+            @isInvalid={{@errors}}
             {{on 'input' (fn this.updateValue R.rowData)}}
           />
         {{else}}
@@ -101,18 +100,27 @@
             @value={{R.rowData.value}}
             disabled={{@disabled}}
             data-test-value-input
+            @isInvalid={{@errors}}
             {{on 'input' (fn this.updateValue R.rowData)}}
           />
         {{/if}}
       </R.Field>
-    {{/if}}
+    {{/unless}}
 
     <R.DeleteRowButton
       data-test-delete-button
       onclick={{fn this.removeRow R.rowData}}
     />
   </:row>
   <:footer as |F|>
+
+    {{#if @errors}}
+      <F.Error as |E|>
+        {{#each @errors as |error|}}
+          <E.Message data-test-error-message>{{error.message}}</E.Message>
+        {{/each}}
+      </F.Error>
+    {{/if}}
     <F.AddRowButton
       @text={{t 'actions.add'}}
       data-test-add-button

ui/admin/app/components/form/field/key-value/index.js

@@ -14,14 +14,18 @@ export default class FormFieldKeyValueComponent extends Component {
     ? [...this.args.data]
     : [this.createEmptyRow()];
 
-  // Determine if the value field should be shown
-  get showValueField() {
-    return this.args.showValueField !== false;
+  /**
+   * Determine if the value field should be shown
+   * Defaults to false (show the value field by default)
+   * @type {boolean}
+   */
+  get hideValueField() {
+    return this.args.hideValueField ?? false;
   }
 
   createEmptyRow() {
     const row = { key: '' };
-    if (this.showValueField) {
+    if (!this.hideValueField) {
       row.value = '';
     }
     return row;