Skip to content

Commit cb89502

Browse files
fix: πŸ› update hidden secrets and flatten-nested-object logic (#2672)
1 parent 2e94ebd commit cb89502

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

β€Žaddons/api/addon/utils/flatten-nested-object.jsβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ export const flattenObject = (obj, result = {}, parentKey = '') => {
1818
if (typeOf(obj[key]) === 'object' && obj[key] !== null) {
1919
// Recursively flatten the object
2020
flattenObject(obj[key], result, `${parentKey}${key}.`);
21-
} else if (obj[key]) {
22-
// Only add to result if the value is not null
21+
} else if (obj[key] !== null && obj[key] !== '') {
22+
// Only add to result if the value is not null or an empty string
2323
result[`${parentKey}${key}`] = obj[key];
2424
}
2525
}

β€Žaddons/api/tests/unit/utils/flatten-nested-object-test.jsβ€Ž

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,16 @@ module('Unit | Utility | flatten-nested-object', function () {
2828
d: {
2929
e: { f: { g: { h: '' } } },
3030
},
31+
i: 0,
32+
j: false,
3133
};
3234
const inputTwo = {
3335
d: { e: null },
3436
};
3537
const expectedResultOne = {
3638
'b.c': 2,
39+
i: 0,
40+
j: false,
3741
};
3842
const expectedResultTwo = {};
3943

β€Žui/desktop/app/components/hidden-secret/index.jsβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export default class HiddenSecretComponent extends Component {
1616
if (typeof this.args.secret === 'object' && this.args.secret !== null) {
1717
return JSON.stringify(this.args.secret, null, 2);
1818
} else {
19-
return this.args.secret;
19+
return this.args.secret.toString();
2020
}
2121
}
2222

0 commit comments

Comments
Β (0)