Skip to content

Commit d86805c

Browse files
committed
refactor: 💡 removed aria-label from button set
This was not sending the aria-label down to the Edit Users detail button. However, taking a look further at Hds::Button, this component does not allow aria-label to be set unless it is an icon only button. With that said, this cleans up the translation structure and removes the aria-label translation and mark-up. ✅ Closes: FE-112
1 parent 334e7d6 commit d86805c

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

‎addons/core/translations/resources/en-us.yaml‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -570,10 +570,7 @@ user:
570570
actions:
571571
add-accounts: Add Accounts
572572
delete: Delete User
573-
edit-details:
574-
button:
575-
text: Edit User details
576-
aria-label: 'edit form: users'
573+
edit-details: 'Edit User details'
577574
role:
578575
title: Role
579576
title_plural: Roles

‎ui/admin/app/components/form/user/index.hbs‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,7 @@
5252

5353
{{#if (can 'save model' @model)}}
5454
<form.actions
55-
@enableEditText={{t 'resources.user.actions.edit-details.button.text'}}
56-
aria-label={{t 'resources.user.actions.edit-details.button.aria-label'}}
55+
@enableEditText={{t 'resources.user.actions.edit-details'}}
5756
@submitText={{t 'actions.save'}}
5857
@cancelText={{t 'actions.cancel'}}
5958
/>

0 commit comments

Comments
 (0)