Fix: Address feedback

Author: dchyun

packages/components/src/components/hds/code-block/index.ts

@@ -100,7 +100,9 @@ export default class HdsCodeBlock extends Component<HdsCodeBlockSignature> {
   });
 
   private _setUpCodeBlockCode = modifier((element: HTMLElement) => {
-    this._isExpanded = false; // reset expanded state on updates
+    if (this.showFooter) {
+      this._isExpanded = false; // reset expanded state on updates
+    }
     this.setPrismCode(element);
     return () => {};
   });
@@ -175,10 +177,10 @@ export default class HdsCodeBlock extends Component<HdsCodeBlockSignature> {
         }
 
         // Existing line numbers must be removed in order to be updated correctly
-        if (element.querySelector('.line-numbers-rows')) {
-          const lineNumbers = element.querySelector(
-            '.line-numbers-rows'
-          ) as HTMLElement;
+        const lineNumbers = element.querySelector(
+          '.line-numbers-rows'
+        ) as HTMLElement;
+        if (lineNumbers) {
           element.removeChild(lineNumbers);
         }
 

showcase/app/styles/showcase-pages/code-block.scss

@@ -13,8 +13,4 @@ body.components-code-block {
       left: 0;
     }
   }
-
-  .shw-component-code-block-demo-btn {
-    margin-top: 12px;
-  }
 }

showcase/app/templates/components/code-block.hbs

@@ -727,7 +727,7 @@ func main() {
         type="button"
         @text="Update"
         @isInline={{true}}
-        class="shw-component-code-block-demo-btn"
+        {{style marginTop="12px"}}
         {{on "click" this.onUpdateClickDemo1}}
       />
     </SF.Item>