typeckecking fixes

#2543 (review)

Author: didoo

packages/flight-icons/scripts/sync-parts/getAssetsMetadata.ts

@@ -5,6 +5,8 @@
 
 import type { AssetCoreData, AssetsMetadata } from "../@types/AssetsMetadata";
 
+import { PublishedComponent, PublishedComponentSet } from '@figma/rest-api-spec';
+
 import { config } from '../config';
 
 import chalk from 'chalk';
@@ -30,10 +32,11 @@ export async function getAssetsMetadata(): Promise<AssetsMetadata> {
     const componentSetsResponse = await api.getFileComponentSets({ file_key: config.figmaFile.id });
     const componentSetData: ComponentSetData = {};
     if (componentSetsResponse.meta && componentSetsResponse.meta.component_sets) {
-        componentSetsResponse.meta.component_sets.forEach(component_set => {
+        componentSetsResponse.meta.component_sets.forEach((component_set: PublishedComponentSet) => {
             // check that the component_set is inside the expected page/frame
             if (
                 component_set.containing_frame &&
+                component_set.containing_frame.name &&
                 component_set.containing_frame.pageName === config.figmaFile.page &&
                 !config.figmaFile.excludeFrames.includes(component_set.containing_frame.name)
             ) {
@@ -49,10 +52,11 @@ export async function getAssetsMetadata(): Promise<AssetsMetadata> {
 
     const componentsResponse = await api.getFileComponents({ file_key: config.figmaFile.id });
     if (componentsResponse.meta && componentsResponse.meta.components) {
-        componentsResponse.meta.components.forEach(component => {
+        componentsResponse.meta.components.forEach((component: PublishedComponent) => {
             // check that the component is inside the expected page/frame
             if (
                 component.containing_frame &&
+                component.containing_frame.name &&
                 component.containing_frame.pageName === config.figmaFile.page &&
                 !config.figmaFile.excludeFrames.includes(component.containing_frame.name)
             ) {
@@ -67,7 +71,12 @@ export async function getAssetsMetadata(): Promise<AssetsMetadata> {
                     // by convention the category of an icon is the containing frame's name
                     assetsMetadata[component.node_id].category = component.containing_frame.name;
                 }
+                // this (missing `containingStateGroup` property) is a known issue:
+                // - https://forum.figma.com/t/missing-containingstategroup-parameter-in-documentation-for-frameinfo/2558
+                // - https://github.com/figma/rest-api-spec/issues/29
+                // @ts-ignore
                 if (component.containing_frame.containingStateGroup) {
+                    // @ts-ignore
                     const parentComponentSet = componentSetData[component.containing_frame.containingStateGroup.nodeId]
                     if (parentComponentSet) {
                         assetsMetadata[component.node_id].iconName = parentComponentSet.name;