fix(components): remove deprecated @task decorator (#3117)

Author: aklkv

packages/components/src/components/hds/time/index.ts

@@ -129,11 +129,11 @@ export default class HdsTime extends Component<HdsTimeSignature> {
   }
 
   @action
-  didInsertNode(): void {
+  async didInsertNode(): Promise<void> {
     const date = this.date;
 
     if (dateIsValid(date)) {
-      this.hdsTime.register(date);
+      await this.hdsTime.register(date);
     }
   }
 

packages/components/src/services/hds-time.ts

@@ -4,11 +4,10 @@
  */
 
 import Service from '@ember/service';
-import { task, timeout } from 'ember-concurrency';
+import { dropTask, timeout } from 'ember-concurrency';
 import { tracked } from '@glimmer/tracking';
 import { DateTime } from 'luxon';
 import { isTesting } from '@embroider/macros';
-import type { TaskGenerator } from 'ember-concurrency';
 import type {
   DisplayType,
   DefaultDisplayType,
@@ -226,12 +225,11 @@ export default class TimeService extends Service {
   }
 
   // Subscribes a listener to the ticking task for time changes.
-  register(id: Date): () => void {
+  async register(id: Date): Promise<() => void> {
     this.#listeners.add(id);
-    // @ts-expect-error - TS2339: Property 'perform' does not exist on type '() => TaskGenerator<string | undefined>'
-    // note: we could potentially use taskFor via `ember-concurrency-ts` to avoid this exception
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-call
-    this.start.perform();
+
+    await this.start.perform();
+
     return (): void => {
       this.unregister(id);
     };
@@ -242,18 +240,17 @@ export default class TimeService extends Service {
     return this.#listeners.delete(id);
   }
 
-  @task({ drop: true })
-  *start(): TaskGenerator<string | undefined> {
+  start = dropTask(async () => {
     while (this.listeners.size) {
       this.now = Date.now();
       // When testing and canceling a EC task, a timer will never resolve and
       // cause the test to hang while waiting for a permanently hanging timeout.
       // This condition breaks the test out of that.
       // via: http://ember-concurrency.com/docs/testing-debugging/
       if (isTesting()) return;
-      yield timeout(SECOND_IN_MS);
+      await timeout(SECOND_IN_MS);
     }
-  }
+  });
 
   // Transforms a JS date to a string representing the UTC ISO date.
   toIsoUtcString(date: Date): string | undefined {

showcase/tests/unit/services/hds-time-test.js

@@ -112,7 +112,7 @@ module('Unit | Service | time', function (hooks) {
     );
   });
 
-  test(`it can register and unregister listeners`, function (assert) {
+  test(`it can register and unregister listeners`, async function (assert) {
     let id = Date.now();
     assert.strictEqual(
       this.service.listeners.size,
@@ -123,7 +123,7 @@ module('Unit | Service | time', function (hooks) {
       this.service.listeners.has(id),
       'the registered id does not exist yet',
     );
-    let unregister = this.service.register(id);
+    let unregister = await this.service.register(id);
     assert.ok(this.service.listeners.has(id), 'the registered id exists');
     assert.strictEqual(
       this.service.listeners.size,