fix: return empty string if invalid date for tooltip text

shleewhite · shleewhite · commit d4d4283d7e5f · 2025-05-14T14:05:53.000-07:00
diff --git a/packages/components/src/components/hds/time/index.hbs b/packages/components/src/components/hds/time/index.hbs
@@ -8,7 +8,6 @@
     {{~#if this.hasTooltip~}}
       <Hds::TooltipButton
         class="hds-time-wrapper"
-        {{! @glint-expect-error: FIXME: pnpm migration }}
         @text={{if
           display.options.tooltipFormat
           (hds-format-date this.date display.options.tooltipFormat)
diff --git a/packages/components/src/components/hds/time/index.ts b/packages/components/src/components/hds/time/index.ts
@@ -87,14 +87,16 @@ export default class HdsTime extends Component<HdsTimeSignature> {
     return this.args.hasTooltip ?? true;
   }
 
-  get isoUtcString(): string | undefined {
+  get isoUtcString(): string {
     const date = this.date;
 
     if (dateIsValid(date)) {
-      return this.hdsTime.toIsoUtcString(date);
+      const isoUtcString = this.hdsTime.toIsoUtcString(date);
+      
+      if (isoUtcString) return isoUtcString;
     }
 
-    return undefined;
+    return '';
   }
 
   get rangeIsoUtcString(): string {

Original file line number	Diff line number	Diff line change
`@@ -87,14 +87,16 @@ export default class HdsTime extends Component<HdsTimeSignature> {`
`87`	`87`	`return this.args.hasTooltip ?? true;`
`88`	`88`	`}`
`89`	`89`
`90`		`- get isoUtcString(): string \| undefined {`
	`90`	`+ get isoUtcString(): string {`
`91`	`91`	`const date = this.date;`
`92`	`92`
`93`	`93`	`if (dateIsValid(date)) {`
`94`		`- return this.hdsTime.toIsoUtcString(date);`
	`94`	`+ const isoUtcString = this.hdsTime.toIsoUtcString(date);`
	`95`	`+`
	`96`	`+ if (isoUtcString) return isoUtcString;`
`95`	`97`	`}`
`96`	`98`
`97`		`- return undefined;`
	`99`	`+ return '';`
`98`	`100`	`}`
`99`	`101`
`100`	`102`	`get rangeIsoUtcString(): string {`