From 4841334b48966950c62f33ec531e7f318545a253 Mon Sep 17 00:00:00 2001 From: Cristiano Rastelli Date: Wed, 14 May 2025 21:19:24 +0100 Subject: [PATCH 1/2] added frameless demo example to `AppSideNav` showcase page --- .../app/templates/components/app-side-nav.hbs | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/showcase/app/templates/components/app-side-nav.hbs b/showcase/app/templates/components/app-side-nav.hbs index 8db073cc55..0e52a6d181 100644 --- a/showcase/app/templates/components/app-side-nav.hbs +++ b/showcase/app/templates/components/app-side-nav.hbs @@ -522,4 +522,19 @@ {{/each}} {{/let}} + + +{{! For some reason, Ember tests don't play well with iframes (URL not found) so we can't take snapshots of these examples in Percy }} +
+ + + + Demo + +
\ No newline at end of file From 1dc4e01f0800f6097463f17176d5aebc13e104d7 Mon Sep 17 00:00:00 2001 From: Cristiano Rastelli Date: Wed, 14 May 2025 21:19:41 +0100 Subject: [PATCH 2/2] removed old code from `AppFrame` showcase page --- .../app/templates/layouts/app-frame/index.hbs | 172 +----------------- 1 file changed, 3 insertions(+), 169 deletions(-) diff --git a/showcase/app/templates/layouts/app-frame/index.hbs b/showcase/app/templates/layouts/app-frame/index.hbs index 626333225c..a03933e7ad 100644 --- a/showcase/app/templates/layouts/app-frame/index.hbs +++ b/showcase/app/templates/layouts/app-frame/index.hbs @@ -185,178 +185,12 @@ /> -
- - - Content - - {{! - Note: The below examples are commented out as they are redundant to the following "Framed" examples. - However we still need to find a solution for adding visual regression tests for the framed examples. - (So we may decide to uncomment these examples to add them back to the visual regression tests depending.) - }} - {{!-- - - - - - <:logo> - - - <:globalActions> - - - - organizationName - - - - <:utilityActions> - - - - Documentation - Tutorials - Terraform Provider - Changelog - - Create support ticket - Give feedback - - - - - - - - - - - - - <:body> - - - - - Services - - - - - - - - - - - Default Org - - - - - - - - - - - - - - - - - - - - - - - - - <:header> - - <:logo> - - - <:actions> - - - - - Documentation - Tutorials - Terraform Provider - Changelog - - Create support ticket - Give feedback - - - - - - Account Settings - - - - - <:body> - - - - - Services - - - - - - - - - - - Default Org - - - - - - - - <:footer> - - - - organizationName - - - - - - - - - - - - - - - - --}} -
- {{! For some reason, Ember tests don't play well with iframes (URL not found) so we can't take snapshots of these examples in Percy }}
- Framed + + + Demo