go: update deps (#127)

Update our dependencies to resolve some proto vulnerabilities

As part of this we also had to resolve some issues with the latest
version of golangci-lint.

* Update Go modules
* Remove .go-version file
* Remove unnecessary copied loop variables
* Range over integers where possible

Signed-off-by: Ryan Cragun <[email protected]>

Author: ryancragun

.github/workflows/build.yml

@@ -44,7 +44,7 @@ jobs:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
       - uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version-file: .go-version
+          go-version-file: go.mod
       - id: product-metadata
         run: |
           make version
@@ -92,7 +92,7 @@ jobs:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
       - uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version-file: .go-version
+          go-version-file: go.mod
       - uses: actions/download-artifact@eaceaf801fd36c7dee90939fad912460b18a1ffe # v4.1.2
         id: download
         with:

.github/workflows/pr_build.yml

@@ -30,7 +30,7 @@ jobs:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
       - uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version-file: .go-version
+          go-version-file: go.mod
       - name: Get Product Version
         id: get-product-version
         run: |

.github/workflows/update_homebrew_formula.yml

@@ -73,7 +73,7 @@ jobs:
           path: enos-checkout
       - uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version-file: enos-checkout/.go-version
+          go-version-file: enos-checkout/go.mod
       # Set up bob CLI
       - name: Setup bob CLI
         uses: hashicorp/action-setup-bob@v1

.github/workflows/validate.yml

@@ -25,7 +25,7 @@ jobs:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
       - uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version-file: .go-version
+          go-version-file: go.mod
       - uses: ./.github/actions/set-up-buf
       - uses: ./.github/actions/set-up-gofumpt
       - uses: ./.github/actions/set-up-golangci-lint
@@ -55,7 +55,7 @@ jobs:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
       - uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version-file: .go-version
+          go-version-file: go.mod
       - uses: hashicorp/setup-terraform@v2
         with:
           # the terraform wrapper will break terraform execution in enos because

.go-version

@@ -37,7 +37,6 @@ func TestAcc_Cmd_Scenario_Check(t *testing.T) {
 			[][]string{{"skip", "keep"}, {"skip", "skip"}},
 		},
 	} {
-		test := test
 		t.Run(fmt.Sprintf("%s %s %s", test.dir, test.name, test.variants), func(t *testing.T) {
 			t.Parallel()
 
@@ -129,7 +128,6 @@ func TestAcc_Cmd_Scenario_Check_WithWarnings(t *testing.T) {
 	t.Cleanup(func() { os.RemoveAll(tmpDir) })
 
 	for _, failOnWarnings := range []bool{true, false} {
-		failOnWarnings := failOnWarnings
 		t.Run(fmt.Sprintf("fail_on_warnings_%t", failOnWarnings), func(t *testing.T) {
 			t.Parallel()
 			outDir := filepath.Join(tmpDir, "scenario_generate_has_warnings")

acceptance/scenario_check_test.go

@@ -44,7 +44,6 @@ func TestAcc_Cmd_Scenario_Destroy(t *testing.T) {
 			false,
 		},
 	} {
-		test := test
 		t.Run(fmt.Sprintf("%s %s %s %t", test.dir, test.name, test.variants, test.launch), func(t *testing.T) {
 			t.Parallel()
 			enos := newAcceptanceRunner(t, skipUnlessTerraformCLI())

acceptance/scenario_destroy_test.go

@@ -50,7 +50,6 @@ func TestAcc_Cmd_Scenario_E2E_AWS(t *testing.T) {
 			},
 		},
 	} {
-		test := test
 		t.Run(test.dir, func(t *testing.T) {
 			t.Parallel()
 

acceptance/scenario_e2e_aws_test.go

@@ -41,7 +41,6 @@ func TestAcc_Cmd_Scenario_Exec(t *testing.T) {
 			fmt.Sprintf("%x", sha256.Sum256([]byte("test [foo:matrixbar]"))),
 		},
 	} {
-		test := test
 		t.Run(fmt.Sprintf("%s %s %s", test.dir, test.name, test.variants), func(t *testing.T) {
 			t.Parallel()
 

acceptance/scenario_exec_test.go

@@ -71,7 +71,6 @@ func TestAcc_Cmd_Scenario_Generate(t *testing.T) {
 			fmt.Sprintf("%x", sha256.Sum256([]byte("kubernetes"))),
 		},
 	} {
-		test := test
 		t.Run(fmt.Sprintf("%s %s %s", test.dir, test.name, test.variants), func(t *testing.T) {
 			t.Parallel()