[QT-330] Only render event diagnostics once (#72)

* Only render event diagnostics once
* Dynamically update the event responses header based on success or
  failure

Signed-off-by: Ryan Cragun <[email protected]>
Co-authored-by: Rebecca Willett [email protected]

Author: ryancragun

command/enos/main.go

@@ -1,7 +1,13 @@
 package main
 
-import "github.com/hashicorp/enos/internal/command/enos/cmd"
+import (
+	"math/rand"
+	"time"
+
+	"github.com/hashicorp/enos/internal/command/enos/cmd"
+)
 
 func main() {
+	rand.Seed(time.Now().UnixNano())
 	cmd.Execute()
 }

internal/ui/basic/show_op_event.go

@@ -53,6 +53,5 @@ func (v *View) ShowOperationEvent(event *pb.Operation_Event) {
 		)...)
 	}
 
-	v.writeDiags(event.GetDiagnostics(), msg)
 	v.writeMsg(event.GetStatus(), msg.String())
 }

internal/ui/basic/show_op_response.go

@@ -2,18 +2,49 @@ package basic
 
 import (
 	"fmt"
+	"math/rand"
 
 	"github.com/hashicorp/enos/internal/diagnostics"
 	"github.com/hashicorp/enos/internal/flightplan"
 	"github.com/hashicorp/enos/internal/ui/status"
 	"github.com/hashicorp/enos/proto/hashicorp/enos/v1/pb"
 )
 
+var failedIcons = []string{"🙈", "🙉", "🙊"}
+
 // ShowOperationResponses shows an operation responses
 func (v *View) ShowOperationResponses(res *pb.OperationResponses) error {
-	// Check for request level diagnostics and fail early if they exist
+	// Determine if anything failed so we can create the correct display header
 	diags := diagnostics.Concat(res.GetDecode().GetDiagnostics(), res.GetDiagnostics())
+	failed := diagnostics.HasFailed(v.Settings().GetFailOnWarnings(), diags)
+	if !failed {
+		for _, r := range res.GetResponses() {
+			if diagnostics.OpResFailed(v.Settings().GetFailOnWarnings(), r) {
+				failed = true
+				break
+			}
+		}
+	}
+
+	header := "\nEnos operations"
+	if failed {
+		if v.settings.IsTty {
+			header = fmt.Sprintf("%s failed! %s\n", header, failedIcons[rand.Intn(len(failedIcons))])
+		} else {
+			header += " failed!\n"
+		}
+	} else {
+		if v.settings.IsTty {
+			header += " finished! 🐵\n"
+		} else {
+			header += " finished!\n"
+		}
+	}
+
 	if diagnostics.HasFailed(v.Settings().GetFailOnWarnings(), diags) {
+		// Our request failed so show our header and request diagnostics
+		v.ui.Error(header)
+
 		err := v.ShowDiagnostics(diags)
 		if err != nil {
 			return err
@@ -22,8 +53,12 @@ func (v *View) ShowOperationResponses(res *pb.OperationResponses) error {
 		return status.OperationResponses(v.Settings().GetFailOnWarnings(), res)
 	}
 
-	// Our request didn't fail so we'll show each operations status
-	v.ui.Info("\nEnos operations finished!\n")
+	if failed {
+		// One or more sub-requests failed
+		v.ui.Error(header)
+	} else {
+		v.ui.Info(header)
+	}
 
 	err := v.ShowDecode(res.GetDecode(), true)
 	if err != nil {

internal/ui/basic/tf_responses.go

@@ -169,7 +169,7 @@ func (v *View) writePlainTextResponse(cmd string, stderr string, res status.ResW
 	if status.HasFailed(v.settings.FailOnWarnings, res) {
 		msg := fmt.Sprintf("  %s: failed!", cmd)
 		if v.settings.IsTty {
-			msg = fmt.Sprintf(" %s: ❌", cmd)
+			msg = fmt.Sprintf("  %s: ❌", cmd)
 		}
 		v.ui.Error(msg)
 		if stderr != "" {