Skip to content

Using custom logger type causes panic at runtime #243

@sochoaAtMulesoft

Description

@sochoaAtMulesoft

ref: main/client.go

Hey all. Can we Update the retryablehttp.Client.Logger field to be one of the following?

  1. A composite interface (ala go 1.18+ generics)?
type RetryableHttpLoggerConstraint interface {
    retryablehttp.Logger | retryablehttp.LeveledLogger
}
func SetLogger[T LoggerConstraint](client *retryablehttp.Client, logger T) {
    client.Logger = logger
}
  1. A single interface (retryablehttp.LeveledLogger or retryablehttp.Logger or something else)

Doing a type check and panic-ing at runtime is no bueno and is likely to cause incidents in production (like it did with us).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions