Skip to content

Commit 3593dd1

Browse files
committed
tests: increase test resiliency
1 parent 56c20c9 commit 3593dd1

File tree

2 files changed

+19
-17
lines changed

2 files changed

+19
-17
lines changed

run_integration_test.go

Lines changed: 9 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -679,22 +679,15 @@ func TestRunsForceCancel_RunDependent(t *testing.T) {
679679
err := client.Runs.Cancel(ctx, rTest.ID, RunCancelOptions{})
680680
require.NoError(t, err)
681681

682-
for i := 1; ; i++ {
683-
// Refresh the view of the run
684-
rTest, err = client.Runs.Read(ctx, rTest.ID)
685-
require.NoError(t, err)
686-
687-
// Check if the timestamp is present.
688-
if !rTest.ForceCancelAvailableAt.IsZero() {
689-
break
690-
}
691-
692-
if i > 30 {
693-
t.Fatal("Timeout waiting for run to be canceled")
694-
}
695-
696-
time.Sleep(time.Second)
697-
}
682+
rTest, err := retryPatientlyIf(
683+
func() (any, error) {
684+
return client.Runs.Read(ctx, rTest.ID)
685+
},
686+
func(r *Run) bool {
687+
return r.ForceCancelAvailableAt.IsZero()
688+
},
689+
)
690+
require.NoError(t, err)
698691

699692
t.Run("force-cancel-available-at timestamp is present", func(t *testing.T) {
700693
assert.True(t, rTest.ForceCancelAvailableAt.After(time.Now()))

workspace_integration_test.go

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2936,7 +2936,16 @@ func TestWorkspaces_AddTags(t *testing.T) {
29362936
require.NoError(t, err)
29372937

29382938
// tag is now in the tag_names
2939-
w, err := client.Workspaces.Read(ctx, orgTest.Name, wTest.Name)
2939+
// retry in case the system is busy
2940+
w, err := retryPatientlyIf(
2941+
func() (any, error) {
2942+
return client.Workspaces.Read(ctx, orgTest.Name, wTest.Name)
2943+
},
2944+
func(w *Workspace) bool {
2945+
return len(w.TagNames) < 5
2946+
},
2947+
)
2948+
29402949
require.NoError(t, err)
29412950
assert.Equal(t, 5, len(w.TagNames))
29422951
sort.Strings(w.TagNames)

0 commit comments

Comments
 (0)