Skip to content

Fix lint job in CI workflow#1123

Merged
brandonc merged 3 commits intomainfrom
brandonc/lint_ci_fix
Jun 9, 2025
Merged

Fix lint job in CI workflow#1123
brandonc merged 3 commits intomainfrom
brandonc/lint_ci_fix

Conversation

@brandonc
Copy link
Copy Markdown
Collaborator

@brandonc brandonc commented Jun 6, 2025

use actions/cache >4, increases timeout

@brandonc brandonc requested a review from a team as a code owner June 6, 2025 15:45
@brandonc brandonc added the no-changelog-needed check changelog entry github workflow label Jun 6, 2025
Copy link
Copy Markdown
Contributor

@hwatkins05-hashicorp hwatkins05-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 💯

steps:
- name: Set up Go
uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm curious why actions/setup-go in test-go-tfe doesn't need to be on the same version as the others, but lgtm!

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Missed one! I updated it

Copy link
Copy Markdown
Contributor

@hwatkins05-hashicorp hwatkins05-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@datadog-terraform-cloud-hashicorp
Copy link
Copy Markdown

datadog-terraform-cloud-hashicorp bot commented Jun 6, 2025

Datadog Report

Branch report: brandonc/lint_ci_fix
Commit report: 1721fc2
Test service: hashicorp/go-tfe

✅ 0 Failed, 1444 Passed, 172 Skipped, 17m 28.18s Total Time
➡️ Test Sessions change in coverage: 1 no change

@brandonc brandonc merged commit 766691b into main Jun 9, 2025
8 checks passed
@brandonc brandonc deleted the brandonc/lint_ci_fix branch June 9, 2025 20:13
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 9, 2025

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-needed check changelog entry github workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants