Skip to content

Implement endpoint for deployment-run list#1134

Merged
shwetamurali merged 10 commits intomainfrom
TF-25652-go_tfe_endpoint_deployment_run_list
Jun 17, 2025
Merged

Implement endpoint for deployment-run list#1134
shwetamurali merged 10 commits intomainfrom
TF-25652-go_tfe_endpoint_deployment_run_list

Conversation

@shwetamurali
Copy link
Copy Markdown
Contributor

@shwetamurali shwetamurali commented Jun 17, 2025

Testing plan

  1. Disable stacks-ga flag in local atlas
  2. Fork pet-nulls-stack or any repo with stacks

Output from tests

go test -v -run TestStackDeploymentRunList
=== RUN   TestStackDeploymentRunList
    stack_deployment_run_integration_test.go:44: Polling stack "st-796PvyFcg1ER48jP" for deployments with deadline of 2025-06-17 13:03:55.168833 -0700 PDT m=+304.901388751
    stack_deployment_run_integration_test.go:44: ...
    stack_deployment_run_integration_test.go:44: Stack "st-796PvyFcg1ER48jP" had 0 deployments
    stack_deployment_run_integration_test.go:44: ...
    stack_deployment_run_integration_test.go:44: Stack "st-796PvyFcg1ER48jP" had 0 deployments
    stack_deployment_run_integration_test.go:44: ...
    stack_deployment_run_integration_test.go:44: Stack "st-796PvyFcg1ER48jP" had 0 deployments
    stack_deployment_run_integration_test.go:44: ...
    stack_deployment_run_integration_test.go:44: Stack "st-796PvyFcg1ER48jP" had 0 deployments
    stack_deployment_run_integration_test.go:44: ...
    stack_deployment_run_integration_test.go:44: Stack "st-796PvyFcg1ER48jP" had 0 deployments
    stack_deployment_run_integration_test.go:44: ...
    stack_deployment_run_integration_test.go:44: Stack "st-796PvyFcg1ER48jP" had 0 deployments
    stack_deployment_run_integration_test.go:44: ...
    stack_deployment_run_integration_test.go:44: Stack "st-796PvyFcg1ER48jP" had 0 deployments
    stack_deployment_run_integration_test.go:44: ...
    stack_deployment_run_integration_test.go:44: Stack "st-796PvyFcg1ER48jP" had 0 deployments
    stack_deployment_run_integration_test.go:44: ...
    stack_deployment_run_integration_test.go:44: Stack "st-796PvyFcg1ER48jP" had 0 deployments
    stack_deployment_run_integration_test.go:44: ...
    stack_deployment_run_integration_test.go:44: Stack "st-796PvyFcg1ER48jP" had 0 deployments
    stack_deployment_run_integration_test.go:44: ...
    stack_deployment_run_integration_test.go:44: Stack "st-796PvyFcg1ER48jP" had 0 deployments
    stack_deployment_run_integration_test.go:44: ...
    stack_deployment_run_integration_test.go:44: Stack "st-796PvyFcg1ER48jP" had 0 deployments
    stack_deployment_run_integration_test.go:44: ...
    stack_deployment_run_integration_test.go:44: Stack "st-796PvyFcg1ER48jP" had 0 deployments
    stack_deployment_run_integration_test.go:44: ...
    stack_deployment_run_integration_test.go:44: Stack "st-796PvyFcg1ER48jP" had 0 deployments
    stack_deployment_run_integration_test.go:44: ...
    stack_deployment_run_integration_test.go:44: Stack "st-796PvyFcg1ER48jP" had 2 deployments
=== RUN   TestStackDeploymentRunList/List_without_options
=== PAUSE TestStackDeploymentRunList/List_without_options
=== RUN   TestStackDeploymentRunList/List_with_pagination
=== PAUSE TestStackDeploymentRunList/List_with_pagination
=== CONT  TestStackDeploymentRunList/List_without_options
=== CONT  TestStackDeploymentRunList/List_with_pagination
--- PASS: TestStackDeploymentRunList (36.60s)
    --- PASS: TestStackDeploymentRunList/List_without_options (0.66s)
    --- PASS: TestStackDeploymentRunList/List_with_pagination (0.66s)
PASS

@shwetamurali shwetamurali changed the title Tf 25652 go tfe endpoint deployment run list Implement endpoint for deployment-run list Jun 17, 2025
@shwetamurali shwetamurali marked this pull request as ready for review June 17, 2025 20:43
@shwetamurali shwetamurali requested a review from a team as a code owner June 17, 2025 20:43
@datadog-terraform-cloud-hashicorp
Copy link
Copy Markdown

datadog-terraform-cloud-hashicorp bot commented Jun 17, 2025

Datadog Report

Branch report: TF-25652-go_tfe_endpoint_deployment_run_list
Commit report: a468e06
Test service: hashicorp/go-tfe

✅ 0 Failed, 1451 Passed, 180 Skipped, 18m 17.56s Total Time
🔻 Test Sessions change in coverage: 1 decreased (-0.1%)

🔻 Code Coverage Decreases vs Default Branch (1)

  • datadog-ci junit upload 59.1% (-0.1%) - Details

Copy link
Copy Markdown
Collaborator

@ctrombley ctrombley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few minor comments/suggestions, nothing big.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider stack_deployment_runs.rb as the filename here for consistency.

Copy link
Copy Markdown
Collaborator

@ctrombley ctrombley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shwetamurali shwetamurali merged commit 4df1be7 into main Jun 17, 2025
8 checks passed
@shwetamurali shwetamurali deleted the TF-25652-go_tfe_endpoint_deployment_run_list branch June 17, 2025 22:01
@github-actions
Copy link
Copy Markdown

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants