added RemoteTFENumericVersion() for TFE numeric version#1246
Merged
Conversation
|
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
from TFE
1.1.0&1.0.3, we have addedX-TFE-Current-Versionheader which returns TFE numeric version value. this pr adds new function/methodRemoteTFENumericVersionto client interface which returns TFE numeric version string, and for earlier TFE versions the function will return empty stringTesting plan
1.1.0or1.0.3docker exec -t terraform-enterprise-tfe-1 tfectl admin tokengo mod tidymain.gofile with below content:go run main.goExternal links
Output from tests
output should be this:
screenshot of the above testing plan:

Rollback Plan
Changes to Security Controls
no