Skip to content

Commit a45fa59

Browse files
authored
build: disable CGO for CRT release (#367)
1 parent d7d4fb3 commit a45fa59

File tree

2 files changed

+6
-15
lines changed

2 files changed

+6
-15
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
## UNRELEASED
22

3+
BUG FIXES:
4+
5+
* build: Removed CGO dependency accidentally introduced in 0.6.0
6+
37
## 0.6.0 (July 12, 2024)
48

59
IMPROVEMENTS:

GNUmakefile

+2-15
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ BIN := $(shell go env GOBIN)
88
ifndef BIN
99
BIN := $(GOPATH)/bin
1010
endif
11-
1211
default: help
1312

1413
HELP_FORMAT=" \033[36m%-25s\033[0m %s\n"
@@ -54,26 +53,13 @@ clean: ## Cleanup previous build
5453
@echo "==> Cleanup previous build"
5554
rm -f ./build/nomad-driver-podman
5655

57-
pkg/%/nomad-driver-podman: GO_OUT ?= $@
58-
pkg/%/nomad-driver-podman: ## Build the nomad-driver-podman plugin for GOOS_GOARCH, e.g. pkg/linux_amd64/nomad-driver-podman
59-
@echo "==> Building $@ with tags $(GO_TAGS)..."
60-
CGO_ENABLED=0 \
61-
GOOS=$(firstword $(subst _, ,$*)) \
62-
GOARCH=$(lastword $(subst _, ,$*)) \
63-
go build -trimpath -o $(GO_OUT)
64-
65-
.PRECIOUS: pkg/%/nomad-driver-podman
66-
pkg/%.zip: pkg/%/nomad-driver-podman ## Build and zip the nomad-driver-podman plugin for GOOS_GOARCH, e.g. pkg/linux_amd64.zip
67-
@echo "==> Packaging for $@..."
68-
@cp LICENSE $(dir $<)LICENSE.txt
69-
zip -j $@ $(dir $<)*
70-
7156
.PHONY: dev
7257
dev: clean build/nomad-driver-podman ## Build the nomad-driver-podman plugin
7358

7459
build/nomad-driver-podman:
7560
@echo "==> Building driver plugin ..."
7661
mkdir -p build
62+
CGO_ENABLED=0 \
7763
go build -o build/nomad-driver-podman .
7864

7965
.PHONY: test
@@ -102,6 +88,7 @@ endif
10288
dist/%/nomad-driver-podman: GO_OUT ?= $@
10389
dist/%/nomad-driver-podman:
10490
@echo "==> RELEASE BUILD of $@ ..."
91+
CGO_ENABLED=0 \
10592
GOOS=linux GOARCH=$(lastword $(subst _, ,$*)) \
10693
go build -trimpath -o $(GO_OUT)
10794

0 commit comments

Comments
 (0)