-
Notifications
You must be signed in to change notification settings - Fork 61
Description
Hello everyone 👋
So I've been trying to implement the use of nomad-pack on my company deployment flow and I've came across a bug as well as a possible feature. I discovered that the problem mentioned in this issue: #522 which was causing nomad-pack to not detect some of my deployed jobs whenever they were deployed in a namespace that contained a dash.
My suggestion would be to improve the regex used to something like this:
namespaceRe := regexp.MustCompile(`(?m)namespace = \"([\w-]+)`)
regionRe := regexp.MustCompile(`(?m)region = \"([\w-]+)`)
This allows nomad-pack to correctly detect the namespace.
In adition i would suggest the implementation of a run option --override-deploy which tells nomad-pack to override the currently deploy job even if it was deployed through other methods.
Would like to hear the team feedback.
Is this something that could be implemented to nomad-pack? (I've currently developed this set of changes but dont seem to have contributions permission to open a PR in this repo)
Metadata
Metadata
Assignees
Labels
Type
Projects
Status