PR feedback

Author: gulducat

.changelog/25598.txt

@@ -1,3 +1,3 @@
 ```release-note:improvement
-task environment: add NOMAD_UNIX_ADDR env var when using workload identity
+task environment: new NOMAD_UNIX_ADDR env var points to the task API unix socket, for use with workload identity
 ```

client/taskenv/env.go

@@ -99,7 +99,7 @@ const (
 	HostAddrPrefix = "NOMAD_HOST_ADDR_"
 
 	// UnixAddr is the task api unix socket, in the appropriate format
-	// for use in a NOMAD_ADDR (i.e. prefixed with "unix:")
+	// for use in a NOMAD_ADDR (i.e. prefixed with "unix://")
 	UnixAddr = "NOMAD_UNIX_ADDR"
 
 	// IpPrefix is the prefix for passing the host IP of a port allocation
@@ -624,12 +624,12 @@ func (b *Builder) buildEnv(allocDir, localDir, secretsDir string,
 	// Build the Nomad Workload Token
 	if b.workloadTokenDefault != "" {
 		envMap[WorkloadToken] = b.workloadTokenDefault
-		envMap[UnixAddr] = "unix:" + filepath.Join(secretsDir, "api.sock")
+		envMap[UnixAddr] = "unix://" + filepath.Join(secretsDir, "api.sock")
 	}
 
 	for name, token := range b.workloadTokens {
 		envMap[WorkloadToken+"_"+name] = token
-		envMap[UnixAddr] = "unix:" + filepath.Join(secretsDir, "api.sock")
+		envMap[UnixAddr] = "unix://" + filepath.Join(secretsDir, "api.sock")
 	}
 
 	// Copy and interpolate task meta

website/content/docs/commands/index.mdx

@@ -66,7 +66,7 @@ may override these environment variables with individual flags.
 
 - `NOMAD_ADDR` - The address of the Nomad server. Defaults to
   `http://127.0.0.1:4646`. For unix sockets, as with the [task API][],
-  the format is `unix:/path/to/api.sock`.
+  the format is either `unix:/path/to/api.sock` or `unix:///path/to/api.sock`.
 
 - `NOMAD_REGION` - The region of the Nomad server to forward commands to.
   Defaults to the Agent's local region

website/content/partials/envvars.mdx

@@ -22,7 +22,7 @@
 | `NOMAD_PARENT_CGROUP`    | The parent cgroup used to contain task cgroups (Linux only)                                                                                                                                                                                                                              |
 | `NOMAD_NAMESPACE`        | Namespace in which the allocation is running                                                                                                                                                                                                                                             |
 | `NOMAD_REGION`           | Region in which the allocation is running                                                                                                                                                                                                                                                |
-| `NOMAD_UNIX_ADDR`        | Use this value as your `NOMAD_ADDR` to use `nomad` CLI with the [task API][]'s unix socket. The value is equivalent to `"unix:${NOMAD_SECRETS_DIR}/api.sock"`
+| `NOMAD_UNIX_ADDR`        | Use this value as your `NOMAD_ADDR` to use `nomad` CLI with the [task API][]'s unix socket. The value is equivalent to `"unix://${NOMAD_SECRETS_DIR}/api.sock"`
 | `NOMAD_META_<key>`       | The metadata value given by `key` on the task's metadata. Any character in a key other than `[A-Za-z0-9_.]` will be converted to `_`. <br/> **Note:** this is different from [`${meta.<key>}`](/nomad/docs/runtime/interpolation#node-variables-) which are keys in the node's metadata. |
 | `CONSUL_HTTP_TOKEN`      | The tasks' Consul token. See [Consul Integration][consul] documentation for more details.                                                                                                                                                                                                |
 | `CONSUL_TOKEN`           | The tasks' Consul token. See [Consul Integration][consul] documentation for more details. This variable is deprecated and exists only for backwards compatibility.                                                                                                                       |