fixing tests

Author: zamoore

ui/app/templates/components/job-editor/edit.hbs

@@ -5,6 +5,7 @@
 
 <div class="boxed-section">
   <Hds::CodeEditor
+    data-test-editor
     @value={{@data.job._newDefinition}}
     @onInput={{@fns.onUpdate}}
     @language={{if (eq @data.format "json") "javascript" "ruby"}}

ui/app/templates/components/job-editor/read.hbs

@@ -53,15 +53,15 @@
         <Hds::CodeBlock
             data-test-job-spec-view
             aria-label="Job specification"
-            @value={{@data.Definition}}
+            @value={{@data.definition}}
             @language={{if (eq @data.format "json") "javascript" "ruby"}}
             @hasLineWrapping={{@data.shouldWrap}}
         />
     {{else}}
         <Hds::CodeBlock
             data-test-json-viewer
             aria-label="JSON Viewer"
-            @value={{@data.Definition}}
+            @value={{@data.definition}}
             @language="json"
             @hasLineWrapping={{@data.shouldWrap}}
         />

ui/tests/integration/components/job-editor-test.js

@@ -6,7 +6,7 @@
 import { assign } from '@ember/polyfills';
 import { module, test } from 'qunit';
 import { setupRenderingTest } from 'ember-qunit';
-import { render } from '@ember/test-helpers';
+import { render, waitFor } from '@ember/test-helpers';
 import hbs from 'htmlbars-inline-precompile';
 import { create } from 'ember-cli-page-object';
 import sinon from 'sinon';
@@ -97,12 +97,19 @@ module('Integration | Component | job-editor', function (hooks) {
       handleSaveAsTemplate: sinon.spy(),
       context: 'new',
     });
+
     await render(commonTemplate);
+
+    return waitFor('.cm-editor');
   };
 
   const planJob = async (spec) => {
     const cm = getCodeMirrorInstance(['data-test-editor']);
-    cm.setValue(spec);
+
+    cm.dispatch({
+      changes: { from: 0, to: cm.state.doc.length, insert: spec },
+    });
+
     await Editor.plan();
   };
 
@@ -123,8 +130,12 @@ module('Integration | Component | job-editor', function (hooks) {
 
     await renderNewJob(this, job);
 
+    await waitFor('.cm-editor');
+
     const cm = getCodeMirrorInstance(['data-test-editor']);
-    cm.setValue(spec);
+    cm.dispatch({
+      changes: { from: 0, to: cm.state.doc.length, insert: spec },
+    });
     await Editor.plan();
 
     const requests = this.server.pretender.handledRequests.mapBy('url');