Skip to content

Commit cfe00ab

Browse files
zamoorezamoore
committed
fixing tests and upgrading dep
1 parent 67561d0 commit cfe00ab

File tree

3 files changed

+42
-31
lines changed

3 files changed

+42
-31
lines changed

‎ui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@
164164
},
165165
"dependencies": {
166166
"@babel/helper-string-parser": "^7.19.4",
167-
"@hashicorp/design-system-components": "4.18.0-rc-20250327210743",
167+
"@hashicorp/design-system-components": "4.18.2",
168168
"@percy/cli": "^1.30.0",
169169
"@percy/ember": "^4.2.0",
170170
"curved-arrows": "^0.1.0",

‎ui/tests/acceptance/job-definition-test.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* SPDX-License-Identifier: BUSL-1.1
44
*/
55

6-
import { click, currentURL, waitFor } from '@ember/test-helpers';
6+
import { click, currentURL, find, waitFor } from '@ember/test-helpers';
77
import percySnapshot from '@percy/ember';
88
import { module, test } from 'qunit';
99
import { setupApplicationTest } from 'ember-qunit';
@@ -175,15 +175,15 @@ module('Acceptance | job definition | full specification', function (hooks) {
175175
assert
176176
.dom('[data-test-select="job-spec"]')
177177
.exists('A select button exists and defaults to full definition');
178-
let codeMirror = getCodeMirrorInstance('[data-test-editor]');
179-
assert.equal(
180-
codeMirror.getValue(),
181-
specification_response.Source,
182-
'Shows the full definition as written by the user'
183-
);
178+
assert
179+
.dom('.hds-code-block__code')
180+
.includesText(specification_response.Source.replace(/\s+/g, ' ').trim());
184181

185182
await click('[data-test-select-full]');
186-
codeMirror = getCodeMirrorInstance('[data-test-editor]');
187-
assert.propContains(JSON.parse(codeMirror.getValue()), JOB_JSON);
183+
184+
const codeBlockCode = find('.hds-code-block__code');
185+
const codeBlockCodeTextContent = codeBlockCode.textContent.trim();
186+
187+
assert.propContains(JSON.parse(codeBlockCodeTextContent), JOB_JSON);
188188
});
189189
});

‎ui/yarn.lock

Lines changed: 32 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2456,14 +2456,14 @@
24562456
resolve "^1.20.0"
24572457
semver "^7.3.2"
24582458

2459-
"@embroider/macros@^1.16.10":
2460-
version "1.16.11"
2461-
resolved "https://registry.yarnpkg.com/@embroider/macros/-/macros-1.16.11.tgz#c8c8c58dac21dd911379ae31fe4f5a53a5cc5a69"
2462-
integrity sha512-TUm/74oBr+tWto0IPAht1g6zjpP7UK0aQdnFHHqGvDPc+tAROQb9jKI/ePEuKAdBCV3L7XvvC4Rlf0DNvT4qmw==
2459+
"@embroider/macros@^1.16.12":
2460+
version "1.17.2"
2461+
resolved "https://registry.yarnpkg.com/@embroider/macros/-/macros-1.17.2.tgz#e1c5fc18bd099e8a076b64701a22655283460073"
2462+
integrity sha512-mgGdufPjL8MAzhYNN1QfHRCFQzv/KEcH9EmObn7y4QC4nPQAPcxEdR8xYZhgTLtKHaVfmN27rXKk+XI7jQAxAg==
24632463
dependencies:
2464-
"@embroider/shared-internals" "2.9.0"
2464+
"@embroider/shared-internals" "3.0.0"
24652465
assert-never "^1.2.1"
2466-
babel-import-util "^2.0.0"
2466+
babel-import-util "^3.0.1"
24672467
ember-cli-babel "^7.26.6"
24682468
find-up "^5.0.0"
24692469
lodash "^4.17.21"
@@ -2547,12 +2547,12 @@
25472547
semver "^7.3.5"
25482548
typescript-memoize "^1.0.1"
25492549

2550-
"@embroider/shared-internals@2.9.0":
2551-
version "2.9.0"
2552-
resolved "https://registry.yarnpkg.com/@embroider/shared-internals/-/shared-internals-2.9.0.tgz#5d945b92e08db163de60d82f7c388e2b7260f0cc"
2553-
integrity sha512-8untWEvGy6av/oYibqZWMz/yB+LHsKxEOoUZiLvcpFwWj2Sipc0DcXeTJQZQZ++otNkLCWyDrDhOLrOkgjOPSg==
2550+
"@embroider/shared-internals@3.0.0":
2551+
version "3.0.0"
2552+
resolved "https://registry.yarnpkg.com/@embroider/shared-internals/-/shared-internals-3.0.0.tgz#98251e6b99d36d64120361a449569ef5384b3812"
2553+
integrity sha512-5J5ipUMCAinQS38WW7wedruq5Z4VnHvNo+ZgOduw0PtI9w0CQWx7/HE+98PBDW8jclikeF+aHwF317vc1hwuzg==
25542554
dependencies:
2555-
babel-import-util "^2.0.0"
2555+
babel-import-util "^3.0.1"
25562556
debug "^4.3.2"
25572557
ember-rfc176-data "^0.3.17"
25582558
fs-extra "^9.1.0"
@@ -2562,6 +2562,7 @@
25622562
minimatch "^3.0.4"
25632563
pkg-entry-points "^1.1.0"
25642564
resolve-package-path "^4.0.1"
2565+
resolve.exports "^2.0.2"
25652566
semver "^7.3.5"
25662567
typescript-memoize "^1.0.1"
25672568

@@ -2839,10 +2840,10 @@
28392840
resolved "https://registry.yarnpkg.com/@handlebars/parser/-/parser-2.0.0.tgz#5e8b7298f31ff8f7b260e6b7363c7e9ceed7d9c5"
28402841
integrity sha512-EP9uEDZv/L5Qh9IWuMUGJRfwhXJ4h1dqKTT4/3+tY0eu7sPis7xh23j61SYUnNF4vqCQvvUXpDo9Bh/+q1zASA==
28412842

2842-
"@hashicorp/[email protected].0-rc-20250327210743":
2843-
version "4.18.0-rc-20250327210743"
2844-
resolved "https://registry.yarnpkg.com/@hashicorp/design-system-components/-/design-system-components-4.18.0-rc-20250327210743.tgz#b5c5400177e3fc041f553e01ffbcbabb2e718c63"
2845-
integrity sha512-XTAr2Wr0+sObyvX3e68aMLRvVgdOc3YunRFjyATvEocufYxZGcGOVxrJ4F+lH5pk+LHt9wWkiI3UQGzWEgfqzA==
2843+
"@hashicorp/[email protected].2":
2844+
version "4.18.2"
2845+
resolved "https://registry.yarnpkg.com/@hashicorp/design-system-components/-/design-system-components-4.18.2.tgz#e0e63d89b7893c173b3f20010f0ffbb72eb12117"
2846+
integrity sha512-mYrgfw8LdZ9iO70I79J/CdhbQb4Tp1os7P8IiA0o86S7RM59F/bGeT3vjeOnxhg3CVguGwEyiXn2LF1jI62DaQ==
28462847
dependencies:
28472848
"@codemirror/commands" "^6.8.0"
28482849
"@codemirror/lang-go" "^6.0.1"
@@ -2860,11 +2861,11 @@
28602861
"@ember/string" "^3.1.1"
28612862
"@ember/test-waiters" "^3.1.0"
28622863
"@embroider/addon-shim" "^1.9.0"
2863-
"@embroider/macros" "^1.16.10"
2864+
"@embroider/macros" "^1.16.12"
28642865
"@embroider/util" "^1.13.2"
28652866
"@floating-ui/dom" "^1.6.12"
28662867
"@hashicorp/design-system-tokens" "^2.3.0"
2867-
"@hashicorp/flight-icons" "^3.9.0"
2868+
"@hashicorp/flight-icons" "^3.10.0"
28682869
"@lezer/highlight" "^1.2.1"
28692870
"@nullvoxpopuli/ember-composable-helpers" "^5.2.9"
28702871
clipboard-polyfill "^4.1.1"
@@ -2892,10 +2893,10 @@
28922893
resolved "https://registry.yarnpkg.com/@hashicorp/design-system-tokens/-/design-system-tokens-2.3.0.tgz#ea05796cad7e573245db90cd9089e44ac5cae5e1"
28932894
integrity sha512-T2XhcgUeiGkNqvPu73yittDghEccUpIZc7Fh/g4PG7KEvJwbXItFWTRWoHSGR8T6r6LpOP5E6CC4hSVwGRugRg==
28942895

2895-
"@hashicorp/flight-icons@^3.9.0":
2896-
version "3.9.0"
2897-
resolved "https://registry.yarnpkg.com/@hashicorp/flight-icons/-/flight-icons-3.9.0.tgz#7a99792560f616d39e4dc4359d094af7c5a1b373"
2898-
integrity sha512-Vh2cLD0LI5JQ3WKmwGMa45f4nbG6HJUZMWUKTF0XmFnEpI9bSpkFvvp9CK8oANMJNSNikDmsQHWg8Hlusi3Bjg==
2896+
"@hashicorp/flight-icons@^3.10.0":
2897+
version "3.10.0"
2898+
resolved "https://registry.yarnpkg.com/@hashicorp/flight-icons/-/flight-icons-3.10.0.tgz#4a6dd8b85c6cc9dabeab33a9ea0d7d390dad16d5"
2899+
integrity sha512-wtufYZ5Ntihmy+vbR0dM+Q7X56xPX/dtpcfVs4nCRgvYZZic5ayqE8tefs2FGtxauH6zuzzVk48s5S6psv9g+g==
28992900

29002901
"@humanwhocodes/config-array@^0.5.0":
29012902
version "0.5.0"
@@ -4374,6 +4375,11 @@ babel-import-util@^3.0.0:
43744375
resolved "https://registry.yarnpkg.com/babel-import-util/-/babel-import-util-3.0.0.tgz#5814c6a58e7b80e64156b48fdfd34d48e6e0b1df"
43754376
integrity sha512-4YNPkuVsxAW5lnSTa6cn4Wk49RX6GAB6vX+M6LqEtN0YePqoFczv1/x0EyLK/o+4E1j9jEuYj5Su7IEPab5JHQ==
43764377

4378+
babel-import-util@^3.0.1:
4379+
version "3.0.1"
4380+
resolved "https://registry.yarnpkg.com/babel-import-util/-/babel-import-util-3.0.1.tgz#62dd0476e855bf57522e1d0027916dc0c0b0fdb2"
4381+
integrity sha512-2copPaWQFUrzooJVIVZA/Oppx/S/KOoZ4Uhr+XWEQDMZ8Rvq/0SNQpbdIyMBJ8IELWt10dewuJw+tX4XjOo7Rg==
4382+
43774383
babel-loader@^8.0.6:
43784384
version "8.3.0"
43794385
resolved "https://registry.yarnpkg.com/babel-loader/-/babel-loader-8.3.0.tgz#124936e841ba4fe8176786d6ff28add1f134d6a8"
@@ -12971,6 +12977,11 @@ resolve-url@^0.2.1:
1297112977
resolved "https://registry.yarnpkg.com/resolve-url/-/resolve-url-0.2.1.tgz#2c637fe77c893afd2a663fe21aa9080068e2052a"
1297212978
integrity sha512-ZuF55hVUQaaczgOIwqWzkEcEidmlD/xl44x1UZnhOXcYuFN2S6+rcxpG+C1N3So0wvNI3DmJICUFfu2SxhBmvg==
1297312979

12980+
resolve.exports@^2.0.2:
12981+
version "2.0.3"
12982+
resolved "https://registry.yarnpkg.com/resolve.exports/-/resolve.exports-2.0.3.tgz#41955e6f1b4013b7586f873749a635dea07ebe3f"
12983+
integrity sha512-OcXjMsGdhL4XnbShKpAcSqPMzQoYkYyhbEaeSko47MjRP9NfEQMhZkXL1DoFlt9LWQn4YttrdnV6X2OiyzBi+A==
12984+
1297412985
resolve@^1.10.0, resolve@^1.10.1, resolve@^1.11.1, resolve@^1.12.0, resolve@^1.13.1, resolve@^1.14.2, resolve@^1.17.0, resolve@^1.20.0, resolve@^1.22.0, resolve@^1.22.8, resolve@^1.3.3, resolve@^1.4.0, resolve@^1.5.0, resolve@^1.8.1:
1297512986
version "1.22.8"
1297612987
resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.22.8.tgz#b6c87a9f2aa06dfab52e3d70ac8cde321fa5a48d"

0 commit comments

Comments
 (0)