fix: improve sata controller error handling

- Utilize `errors.Is` for accurate error comparison when checking for `ErrNoSataController`, allowing for correct handling of wrapped errors.
- Implement error wrapping with `%w` in `fmt.Errorf` to preserve underlying error information.
- Add handling for unexpected error conditions from `FindSATAController` to ensure robustness.

Signed-off-by: Ryan Johnson <[email protected]>

Author: tenthirtyam

builder/vsphere/common/step_add_cdrom.go

@@ -8,6 +8,7 @@ package common
 
 import (
 	"context"
+	"errors"
 	"fmt"
 
 	"github.com/hashicorp/packer-plugin-sdk/multistep"
@@ -81,10 +82,15 @@ func (s *StepAddCDRom) Run(_ context.Context, state multistep.StateBag) multiste
 	vm := state.Get("vm").(driver.VirtualMachine)
 
 	if s.Config.CdromType == "sata" {
-		if _, err := vm.FindSATAController(); err == driver.ErrNoSataController {
+		if _, err := vm.FindSATAController(); err != nil {
+			if !errors.Is(err, driver.ErrNoSataController) {
+				state.Put("error", fmt.Errorf("unexpected error finding SATA controller: %w", err))
+				return multistep.ActionHalt
+			}
+
 			ui.Say("Adding SATA controller...")
 			if err := vm.AddSATAController(); err != nil {
-				state.Put("error", fmt.Errorf("error adding SATA controller: %v", err))
+				state.Put("error", fmt.Errorf("error adding SATA controller: %w", err))
 				return multistep.ActionHalt
 			}
 		}