review nits and remove redundant matrix related config from workflows

Author: jackofallops

.github/workflows/unit-test-data-api-differ.yaml

@@ -10,8 +10,6 @@ on:
 jobs:
   test:
     runs-on: ubuntu-latest
-    strategy:
-      fail-fast: true
     steps:
       - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
         with:

.github/workflows/unit-test-data-api-v2.yaml

@@ -11,8 +11,6 @@ on:
 jobs:
   test:
     runs-on: ubuntu-latest
-    strategy:
-      fail-fast: true
     steps:
       - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
         with:

tools/data-api/internal/endpoints/routing.go

@@ -37,7 +37,7 @@ func Router(workingDirectory string, serviceNames *[]string) func(chi.Router) {
 			}
 			v1.Router(r, opts, serviceRepo)
 		})
-		router.Route("/v1/data-plane/", func(r chi.Router) {
+		router.Route("/v1/data-plane", func(r chi.Router) {
 			opts := v1.Options{
 				ServiceType: sdkModels.DataPlaneSourceDataType,
 				UriPrefix:   "/v1/data-plane",

tools/generator-go-sdk/internal/cmd/generate.go

@@ -107,7 +107,6 @@ func (g GenerateCommand) Run(args []string) int {
 			input.settings.DeleteExistingResourcesForVersion = false
 			input.settings.GenerateDescriptionsForModels = false
 			input.settings.RecurseParentModels = true
-			// input.settings.UseOldBaseLayerFor("KeyVault")
 		}
 	}
 

tools/generator-go-sdk/internal/generator/templater_id_parser.go

@@ -160,12 +160,12 @@ func (r *resourceIdTemplater) methods(sourceType models.SourceDataType) (*string
 	if sourceType == models.DataPlaneSourceDataType {
 		functionBody, err = r.pathFunction()
 		if err != nil {
-			return nil, fmt.Errorf("generating ID function: %+v", err)
+			return nil, fmt.Errorf("generating Path function: %+v", err)
 		}
 		methods = append(methods, *functionBody)
 		functionBody, err = r.pathElementsFunction()
 		if err != nil {
-			return nil, fmt.Errorf("generating ID function: %+v", err)
+			return nil, fmt.Errorf("generating PathElements function: %+v", err)
 		}
 		methods = append(methods, *functionBody)
 	}

tools/importer-rest-api-specs/internal/cmd/import_data_plane.go

@@ -19,15 +19,15 @@ func NewImportDataPlaneCommand(restAPISpecsRepositoryDirectoryPath, datPlaneConf
 	return func() (cli.Command, error) {
 		return ImportDataPlaneCommand{
 			outputDirectory:                     outputDirectory,
-			datPlaneConfigPath:                  datPlaneConfigPath,
+			dataPlaneConfigPath:                 datPlaneConfigPath,
 			restAPISpecsRepositoryDirectoryPath: restAPISpecsRepositoryDirectoryPath,
 		}, nil
 	}
 }
 
 type ImportDataPlaneCommand struct {
 	outputDirectory                     string
-	datPlaneConfigPath                  string
+	dataPlaneConfigPath                 string
 	restAPISpecsRepositoryDirectoryPath string
 }
 
@@ -52,7 +52,7 @@ func (c ImportDataPlaneCommand) Run(args []string) int {
 
 	opts := pipeline.Options{
 		APIDefinitionsDirectory: c.outputDirectory,
-		ConfigFilePath:          c.datPlaneConfigPath,
+		ConfigFilePath:          c.dataPlaneConfigPath,
 		ProviderPrefix:          "azurerm",
 		RestAPISpecsDirectory:   c.restAPISpecsRepositoryDirectoryPath,
 		ServiceNamesToLimitTo:   serviceNames,

tools/importer-rest-api-specs/internal/components/discovery/for_api_version.go

@@ -30,7 +30,6 @@ func discoverDataSetForAPIVersion(apiVersion string, filePaths []string, sourceD
 			// So just handling the directory name here is fine
 			shouldIgnore := false
 			for _, item := range strings.Split(filePath, fmt.Sprintf("%c", filepath.Separator)) {
-				// TODO - Fix this
 				switch {
 				case sourceDataType == sdkModels.DataPlaneSourceDataType && strings.EqualFold(item, "resource-manager"):
 					logging.Tracef("path contains `resource-manager`, skipping..")