Unmet peer dependencies for the cli

[paymog]

cdktf & Language Versions

typescript 0.12.2

Issue

I just installed the cdktf-cli at version 0.12.2 and I'm seeing it has unmet peer dependencies. Is this by design?

$ yarn add cdktf@latest cdktf-cli@latest
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
[4/5] 🔗  Linking dependencies...
warning "cdktf-cli > ink-select-input@4.2.1" has unmet peer dependency "ink@^3.0.5".
warning "cdktf-cli > ink-select-input@4.2.1" has unmet peer dependency "react@^16.5.2 || ^17.0.0".
warning "cdktf-cli > @cdktf/hcl2cdk > graphology@0.24.1" has incorrect peer dependency "graphology-types@>=0.24.0".

I know I can install these dependencies myself but it seems unusual that a cli would require react.

[ansgarm]

Hi @paymog 👋

We're using ink for the terminal UI, which is React based.

Regarding the unmet peer dependencies: We bundle the entrypoint to our CLI, which contains the peer dependencies (they are inlined). However, we still distribute the lib directory, so users could do e.g. import xy from 'cdktf-cli/lib/some-internal-thing (related to #1377) – for which those peer dependencies make sense to specify but they aren't required for using the cli itself.

This is a bit tricky, but I feel that we might fix it by changing the peer dependencies to normal dependencies to get rid of that warning – especially since (when importing from the package directly), users won't have to manually install all the missing dependencies by hand 🤔