`azurerm` provider: priority field should be required field in Network Security Group

[chun-ko]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

cdktf & Language Versions

Affected Provider / Resource(s)

Debug Output

This priority should be required field instead of optional

https://github.com/cdktf/cdktf-provider-azurerm/blob/970b1a9f6a6c2b9fd9e44c575836675e4bd9c3fc/src/network-security-group/index.ts#L84

Base on the documentation https://www.terraform.io/docs/providers/azurerm/r/network_security_group#priority

Expected Behavior

Actual Behavior

Steps to Reproduce

Important Factoids

References

• #0000

[mutahhir]

The security_rule block has the following schema:

              "security_rule": {
                "type": [
                  "set",
                  [
                    "object",
                    {
                      "access": "string",
                      "description": "string",
                      "destination_address_prefix": "string",
                      "destination_address_prefixes": [
                        "set",
                        "string"
                      ],
                      "destination_application_security_group_ids": [
                        "set",
                        "string"
                      ],
                      "destination_port_range": "string",
                      "destination_port_ranges": [
                        "set",
                        "string"
                      ],
                      "direction": "string",
                      "name": "string",
                      "priority": "number",
                      "protocol": "string",
                      "source_address_prefix": "string",
                      "source_address_prefixes": [
                        "set",
                        "string"
                      ],
                      "source_application_security_group_ids": [
                        "set",
                        "string"
                      ],
                      "source_port_range": "string",
                      "source_port_ranges": [
                        "set",
                        "string"
                      ]
                    }
                  ]
                ],
                "description_kind": "plain",
                "optional": true,
                "computed": true
              },

@DanielMSchmidt will probably know more about this, but I think we're making all these optional because the schema does not define any object members as required or optional. I feel like this is a problem that would require some work from the azurerm provider to change the type of the security_rule to be an attribute block, or Terraform introducing required / optional within object attributes.

Leaving this open for further discussion, but I'm unsure if we can resolve this on the CDKTF end.