Commit 12680b6
committed
Remove env.configFilePath and env.secretsFilePath
These utilize `.Files.Get` in Helm
Per the Helm docs (https://helm.sh/docs/chart_template_guide/accessing_files/):
> Some files cannot be accessed through the .Files object, usually for security reasons.
> Files outside of a Helm application subchart, including those of the parent, cannot be accessed
Because of this, `.env.configFilePath` and `env.secretsFilePath` are only ever usable if you have a copy of this repo in your local directory when installing. When installing the Helm chart through the https://helm.releases.hashicorp.com release, because the chart is pulled from the HashiCorp repo, these files are not considered a part of the chart, causing `.env.configFilePath` and `env.secretsFilePath` to always be a no-op.
This has caused confusion on a support ticket, so I propose we remove these two values entirely.
Examples/proof:
Working because we edit the chart itself (install `.`)
```bash
echo 'TFE_HOSTNAME: "testing"' > env-config.yaml
helm template tfe . --set "env.configFilePath=`pwd`/env-config.yaml"
```
Not working because we are pulling from the HashiCorp repo
```bash
echo 'TFE_HOSTNAME: "testing"' > env-config.yaml
helm template tfe hashicorp/terraform-enterprise --set "env.configFilePath=`pwd`/env-config.yaml"
```1 parent 21761d7 commit 12680b6
File tree
6 files changed
+0
-76
lines changed- templates
6 files changed
+0
-76
lines changedThis file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | 87 | | |
102 | 88 | | |
103 | 89 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | | - | |
35 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | | - | |
41 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
224 | 224 | | |
225 | 225 | | |
226 | 226 | | |
227 | | - | |
228 | | - | |
229 | 227 | | |
230 | 228 | | |
231 | 229 | | |
| |||
0 commit comments