Module output completion broken if 2+ modules have the same source

[radeksimko]

Server Version

0.29.3

Client Version

2.24.3-darwin-arm64

Terraform Configuration Files

module "alpha" {
  source = "./submod"
}

module "beta" {
  source = "./submod"
}

output "name" {
  value = module. # completion HERE
}

Expected Behavior

Actual Behavior

Additional Context

There's a naive simple fix in https://github.com/hashicorp/terraform-schema/pull/158/files but that may have some other side effects in other contexts.

It's also related to #895

[bgshacklett]

note: my editor is NeoVim, using the built-in language server host
This seems to go deeper than just completing the module name. If we take this a step further:

module "alpha" {
  source = "./modules/example"
}

module "beta" {
  source = "./modules/example"
}

output "name" {
  value = module.alpha. # completion here
}

I'm finding that I often don't get any completion attempts in the above location:

If I keep trying enough times, though, I might get something eventually:

I also see my references remain unresolved in a number of locations, leading to uncertainty around whether I've got the right identifiers in place or not:

@radeksimko Could you give us a bit more insight into what's going on in your example PR?