Skip to content

Report duplicate blocks #1590

Open
Open
@radeksimko

Description

@radeksimko

Background

One of the common issues users face is that they end up with duplicate blocks. This can be a result of copy pasting or just complex module with many files that make it difficult to keep track of all blocks.

This concerns blocks which are addressable and need to be unique within the module "namespace":

  • check
  • data
  • locals
  • module
  • output
  • resource
  • variable

Proposal

  • Report duplicate check "<name>" as error
  • Report duplicate data ... "<name>" as error
  • Report duplicate locals entries as error
  • Report duplicate module ""` as error
  • Report duplicate output "<name>" as error
  • Report duplicate resource ... "<name>" as error
  • Report duplicate variable "<name>" as error
  • Provide quickfix code action to remove duplicate check "<name>"
  • Provide quickfix code action to remove duplicate data ... "<name>"
  • Provide quickfix code action to remove duplicate locals entries
  • Provide quickfix code action to remove duplicate module ""`
  • Provide quickfix code action to remove duplicate output "<name>"
  • Provide quickfix code action to remove duplicate resource ... "<name>"
  • Provide quickfix code action to remove duplicate variable "<name>"

Notes

We already track similar enhancement for tfvars entries:

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions