Updates Semgrep checks for error checking patterns

Author: gdavison

.ci/semgrep/retry/retry.yml

@@ -7,3 +7,12 @@ rules:
     fix: |
       retry.NotFound($ERR)
     severity: ERROR
+
+  - id: internal-retry-timedout
+    languages: [go]
+    message: "Prefer retry.TimedOut to tfresource.TimedOut"
+    pattern: |
+      tfresource.TimedOut($ERR)
+    fix: |
+      retry.TimedOut($ERR)
+    severity: ERROR

internal/vcr/.semgrep-vcr.yml

@@ -222,18 +222,6 @@ rules:
       include:
         - "**/*.go"
 
-  - id: internal-retry-timedout
-    languages: [go]
-    message: "Use retry.TimedOut to replace the deprecated tfresource alias"
-    severity: WARNING
-    pattern: |
-      tfresource.TimedOut($ERR)
-    fix: |
-      retry.TimedOut($ERR)
-    paths:
-      include:
-        - "**/*.go"
-
   - id: internal-retry-setlasterror
     languages: [go]
     message: "Use retry.SetLastError to replace the deprecated tfresource alias"