automation: split resourceAutomationWebhookCreateUpdate into Create and Update

Split the shared resourceAutomationWebhookCreateUpdate function into
separate resourceAutomationWebhookCreate and resourceAutomationWebhookUpdate
functions.

Create uses client.CreateOrUpdate (PUT) with existence check and URI
generation logic.

Update uses client.Update (PATCH) with HasChanges guards for the
updatable fields (enabled, run_on_worker_group, parameters). The URI
is sensitive and not returned by the API, so it is preserved from state.

Author: katbyte

internal/services/automation/automation_webhook_resource.go

@@ -25,9 +25,9 @@ import (
 
 func resourceAutomationWebhook() *pluginsdk.Resource {
 	return &pluginsdk.Resource{
-		Create: resourceAutomationWebhookCreateUpdate,
+		Create: resourceAutomationWebhookCreate,
 		Read:   resourceAutomationWebhookRead,
-		Update: resourceAutomationWebhookCreateUpdate,
+		Update: resourceAutomationWebhookUpdate,
 		Delete: resourceAutomationWebhookDelete,
 
 		Importer: pluginsdk.ImporterValidatingResourceId(func(id string) error {
@@ -108,65 +108,52 @@ func resourceAutomationWebhook() *pluginsdk.Resource {
 	}
 }
 
-func resourceAutomationWebhookCreateUpdate(d *pluginsdk.ResourceData, meta interface{}) error {
+func resourceAutomationWebhookCreate(d *pluginsdk.ResourceData, meta interface{}) error {
 	client := meta.(*clients.Client).Automation.WebhookClient
 	subscriptionId := meta.(*clients.Client).Account.SubscriptionId
-	ctx, cancel := timeouts.ForCreateUpdate(meta.(*clients.Client).StopContext, d)
+	ctx, cancel := timeouts.ForCreate(meta.(*clients.Client).StopContext, d)
 	defer cancel()
 
 	id := webhook.NewWebHookID(subscriptionId, d.Get("resource_group_name").(string), d.Get("automation_account_name").(string), d.Get("name").(string))
-	expiryTime := d.Get("expiry_time").(string)
-	enabled := d.Get("enabled").(bool)
-	runbookName := d.Get("runbook_name").(string)
-	runOn := d.Get("run_on_worker_group").(string)
-	webhookParameters := expandStringInterfaceMap(d.Get("parameters").(map[string]interface{}))
-
-	if d.IsNewResource() {
-		resp, err := client.Get(ctx, id)
-		if err != nil {
-			if !response.WasNotFound(resp.HttpResponse) {
-				return fmt.Errorf("checking for presence of existing %s: %+v", id, err)
-			}
-		}
 
-		if resp.Model != nil && resp.Model.Id != nil && *resp.Model.Id != "" {
-			return tf.ImportAsExistsError("azurerm_automation_webhook", *resp.Model.Id)
+	resp, err := client.Get(ctx, id)
+	if err != nil {
+		if !response.WasNotFound(resp.HttpResponse) {
+			return fmt.Errorf("checking for presence of existing %s: %+v", id, err)
 		}
 	}
 
+	if resp.Model != nil && resp.Model.Id != nil && *resp.Model.Id != "" {
+		return tf.ImportAsExistsError("azurerm_automation_webhook", *resp.Model.Id)
+	}
+
 	parameters := webhook.WebhookCreateOrUpdateParameters{
 		Name: id.WebHookName,
 		Properties: webhook.WebhookCreateOrUpdateProperties{
-			IsEnabled:  pointer.To(enabled),
-			ExpiryTime: &expiryTime,
-			Parameters: &webhookParameters,
+			IsEnabled:  pointer.To(d.Get("enabled").(bool)),
+			ExpiryTime: pointer.To(d.Get("expiry_time").(string)),
+			Parameters: pointer.To(expandStringInterfaceMap(d.Get("parameters").(map[string]interface{}))),
 			Runbook: &webhook.RunbookAssociationProperty{
-				Name: pointer.To(runbookName),
+				Name: pointer.To(d.Get("runbook_name").(string)),
 			},
-			RunOn: pointer.To(runOn),
+			RunOn: pointer.To(d.Get("run_on_worker_group").(string)),
 		},
 	}
 
 	uri := ""
-	if d.IsNewResource() {
-		if v := d.Get("uri"); v != nil && v.(string) != "" {
-			uri = v.(string)
-			parameters.Properties.Uri = &uri
-		} else {
-			automationAccountId := webhook.NewAutomationAccountID(subscriptionId, id.ResourceGroupName, id.AutomationAccountName)
-			resp, err := client.GenerateUri(ctx, automationAccountId)
-			if err != nil {
-				return fmt.Errorf("unable to generate URI for %s: %+v", id, err)
-			}
-
-			parameters.Properties.Uri = resp.Model
-			if resp.Model != nil {
-				uri = *resp.Model
-			}
-		}
+	if v := d.Get("uri"); v != nil && v.(string) != "" {
+		uri = v.(string)
+		parameters.Properties.Uri = &uri
 	} else {
-		if d.Get("uri") != nil {
-			parameters.Properties.Uri = pointer.To(d.Get("uri").(string))
+		automationAccountId := webhook.NewAutomationAccountID(subscriptionId, id.ResourceGroupName, id.AutomationAccountName)
+		resp, err := client.GenerateUri(ctx, automationAccountId)
+		if err != nil {
+			return fmt.Errorf("unable to generate URI for %s: %+v", id, err)
+		}
+
+		parameters.Properties.Uri = resp.Model
+		if resp.Model != nil {
+			uri = *resp.Model
 		}
 	}
 
@@ -182,6 +169,61 @@ func resourceAutomationWebhookCreateUpdate(d *pluginsdk.ResourceData, meta inter
 	return resourceAutomationWebhookRead(d, meta)
 }
 
+func resourceAutomationWebhookUpdate(d *pluginsdk.ResourceData, meta interface{}) error {
+	client := meta.(*clients.Client).Automation.WebhookClient
+	ctx, cancel := timeouts.ForUpdate(meta.(*clients.Client).StopContext, d)
+	defer cancel()
+
+	id, err := webhook.ParseWebHookID(d.Id())
+	if err != nil {
+		return err
+	}
+
+	resp, err := client.Get(ctx, *id)
+	if err != nil {
+		return fmt.Errorf("retrieving %s: %+v", *id, err)
+	}
+
+	if resp.Model == nil || resp.Model.Properties == nil {
+		return fmt.Errorf("retrieving %s: model or properties was nil", *id)
+	}
+
+	existing := resp.Model.Properties
+
+	parameters := webhook.WebhookUpdateParameters{
+		Name: pointer.To(id.WebHookName),
+		Properties: &webhook.WebhookUpdateProperties{
+			IsEnabled:  existing.IsEnabled,
+			RunOn:      existing.RunOn,
+			Parameters: existing.Parameters,
+		},
+	}
+
+	if d.HasChange("enabled") {
+		parameters.Properties.IsEnabled = pointer.To(d.Get("enabled").(bool))
+	}
+
+	if d.HasChange("run_on_worker_group") {
+		parameters.Properties.RunOn = pointer.To(d.Get("run_on_worker_group").(string))
+	}
+
+	// NOTE: parameters is a map that is replaced as a whole
+	if d.HasChange("parameters") {
+		parameters.Properties.Parameters = pointer.To(expandStringInterfaceMap(d.Get("parameters").(map[string]interface{})))
+	}
+
+	if _, err := client.Update(ctx, *id, parameters); err != nil {
+		return fmt.Errorf("updating %s: %+v", *id, err)
+	}
+
+	// URI is not present in the response from Azure, preserve from state
+	if v := d.Get("uri"); v != nil && v.(string) != "" {
+		d.Set("uri", v.(string))
+	}
+
+	return resourceAutomationWebhookRead(d, meta)
+}
+
 func resourceAutomationWebhookRead(d *pluginsdk.ResourceData, meta interface{}) error {
 	client := meta.(*clients.Client).Automation.WebhookClient
 	ctx, cancel := timeouts.ForRead(meta.(*clients.Client).StopContext, d)