test: analysisservices, appinsights, arckubernetes, authorization, automation - various acceptance test fixes (#32470)

Author: toddgiguere

internal/services/analysisservices/analysis_services_server_resource_test.go

@@ -487,7 +487,7 @@ resource "azurerm_storage_account" "test" {
 
 resource "azurerm_storage_container" "test" {
   name                  = "assbackup"
-  storage_account_name  = azurerm_storage_account.test.name
+  storage_account_id    = azurerm_storage_account.test.id
   container_access_type = "private"
 }
 

internal/services/applicationinsights/application_insights_workbook_resource_test.go

@@ -302,7 +302,7 @@ resource "azurerm_storage_account" "test" {
 
 resource "azurerm_storage_container" "test" {
   name                  = "test"
-  storage_account_name  = azurerm_storage_account.test.name
+  storage_account_id    = azurerm_storage_account.test.id
   container_access_type = "private"
 }
 
@@ -377,7 +377,7 @@ resource "azurerm_storage_account" "test" {
 
 resource "azurerm_storage_container" "test" {
   name                  = "test"
-  storage_account_name  = azurerm_storage_account.test.name
+  storage_account_id    = azurerm_storage_account.test.id
   container_access_type = "private"
 }
 
@@ -452,7 +452,7 @@ resource "azurerm_storage_account" "test" {
 
 resource "azurerm_storage_container" "test" {
   name                  = "test"
-  storage_account_name  = azurerm_storage_account.test.name
+  storage_account_id    = azurerm_storage_account.test.id
   container_access_type = "private"
 }
 
@@ -527,7 +527,7 @@ resource "azurerm_storage_account" "test" {
 
 resource "azurerm_storage_container" "test" {
   name                  = "test"
-  storage_account_name  = azurerm_storage_account.test.name
+  storage_account_id    = azurerm_storage_account.test.id
   container_access_type = "private"
 }
 

internal/services/arckubernetes/arc_kubernetes_flux_configuration_resource_test.go

@@ -408,7 +408,7 @@ resource "azurerm_storage_account" "test" {
 
 resource "azurerm_storage_container" "test" {
   name                  = "asc%[2]d"
-  storage_account_name  = azurerm_storage_account.test.name
+  storage_account_id    = azurerm_storage_account.test.id
   container_access_type = "private"
 }
 
@@ -453,7 +453,7 @@ resource "azurerm_storage_account" "test" {
 
 resource "azurerm_storage_container" "test" {
   name                  = "asc%[2]d"
-  storage_account_name  = azurerm_storage_account.test.name
+  storage_account_id    = azurerm_storage_account.test.id
   container_access_type = "private"
 }
 
@@ -541,7 +541,7 @@ resource "azurerm_storage_account" "test" {
 
 resource "azurerm_storage_container" "test" {
   name                  = "asc%[2]d"
-  storage_account_name  = azurerm_storage_account.test.name
+  storage_account_id    = azurerm_storage_account.test.id
   container_access_type = "private"
 }
 
@@ -611,7 +611,7 @@ resource "azurerm_storage_account" "test" {
 
 resource "azurerm_storage_container" "test" {
   name                  = "asc%[2]d"
-  storage_account_name  = azurerm_storage_account.test.name
+  storage_account_id    = azurerm_storage_account.test.id
   container_access_type = "private"
 }
 

internal/services/authorization/marketplace_role_assignment_resource_test.go

@@ -72,7 +72,7 @@ func TestAccRoleAssignmentMarketplace_requiresImport(t *testing.T) {
 	id := uuid.New().String()
 
 	r := RoleAssignmentMarketplaceResource{}
-	roleName := "Managed Applications Reader"
+	roleName := "ContainerApp Reader"
 
 	data.ResourceSequentialTest(t, r, []acceptance.TestStep{
 		{
@@ -310,7 +310,7 @@ provider "azurerm" {
 resource "azurerm_marketplace_role_assignment" "test" {
   name                 = "%s"
   role_definition_name = "%s"
-  principal_id         = azuread_service_principal.test.id
+  principal_id         = azuread_service_principal.test.object_id
 
   lifecycle {
     ignore_changes = [
@@ -340,7 +340,7 @@ provider "azurerm" {
 resource "azurerm_marketplace_role_assignment" "test" {
   name                             = "%s"
   role_definition_name             = "%s"
-  principal_id                     = azuread_service_principal.test.id
+  principal_id                     = azuread_service_principal.test.object_id
   skip_service_principal_aad_check = true
 
   lifecycle {

internal/services/authorization/role_assignment_resource_test.go

@@ -511,7 +511,7 @@ resource "azurerm_role_assignment" "test" {
   name                 = "%s"
   scope                = data.azurerm_subscription.current.id
   role_definition_name = "Reader"
-  principal_id         = azuread_service_principal.test.id
+  principal_id         = azuread_service_principal.test.object_id
 }
 `, rInt, roleAssignmentID)
 }
@@ -539,7 +539,7 @@ resource "azurerm_role_assignment" "test" {
   name                             = "%s"
   scope                            = data.azurerm_subscription.current.id
   role_definition_name             = "Reader"
-  principal_id                     = azuread_service_principal.test.id
+  principal_id                     = azuread_service_principal.test.object_id
   skip_service_principal_aad_check = true
 }
 `, rInt, roleAssignmentID)

internal/services/authorization/role_definition_data_source_test.go

@@ -73,7 +73,7 @@ func TestAccRoleDefinitionDataSource_builtIn_contributor(t *testing.T) {
 				check.That(data.ResourceName).Key("permissions.#").HasValue("1"),
 				check.That(data.ResourceName).Key("permissions.0.actions.#").HasValue("1"),
 				check.That(data.ResourceName).Key("permissions.0.actions.0").HasValue("*"),
-				check.That(data.ResourceName).Key("permissions.0.not_actions.#").HasValue("9"),
+				check.That(data.ResourceName).Key("permissions.0.not_actions.#").HasValue("11"),
 				check.That(data.ResourceName).Key("permissions.0.not_actions.0").HasValue("Microsoft.Authorization/*/Delete"),
 				check.That(data.ResourceName).Key("permissions.0.not_actions.1").HasValue("Microsoft.Authorization/*/Write"),
 				check.That(data.ResourceName).Key("permissions.0.not_actions.2").HasValue("Microsoft.Authorization/elevateAccess/Action"),

internal/services/automation/automation_account_resource_test.go

@@ -354,7 +354,7 @@ resource "azurerm_key_vault" "test" {
   sku_name                   = "standard"
   soft_delete_retention_days = 7
   purge_protection_enabled   = true
-  enable_rbac_authorization  = true
+  rbac_authorization_enabled = true
 }
 
 resource "azurerm_role_assignment" "current" {

internal/services/automation/automation_watcher_resource_test.go

@@ -114,7 +114,7 @@ resource "azurerm_automation_watcher" "test" {
   }
 
   script_parameters = {
-    foo = "bar"
+    param_foo = "arg_bar"
   }
 
   etag                           = "etag example"