convert public access attrib to arg

Author: wyattfry

internal/services/mysql/mysql_flexible_server_configuration_resource_test.go

@@ -275,13 +275,14 @@ resource "azurerm_resource_group" "test" {
 }
 
 resource "azurerm_mysql_flexible_server" "test" {
-  name                   = "acctest-fs-%d"
-  resource_group_name    = azurerm_resource_group.test.name
-  location               = azurerm_resource_group.test.location
-  administrator_login    = "adminTerraform"
-  administrator_password = "QAZwsx123"
-  sku_name               = "B_Standard_B1s"
-  zone                   = "1"
+  name                          = "acctest-fs-%d"
+  resource_group_name           = azurerm_resource_group.test.name
+  location                      = azurerm_resource_group.test.location
+  administrator_login           = "adminTerraform"
+  administrator_password        = "QAZwsx123"
+  public_network_access_enabled = false
+  sku_name                      = "B_Standard_B1s"
+  zone                          = "1"
 }
 `, data.RandomInteger, data.Locations.Primary, data.RandomInteger)
 }

internal/services/mysql/mysql_flexible_server_resource.go

@@ -298,7 +298,8 @@ func resourceMysqlFlexibleServer() *pluginsdk.Resource {
 
 			"public_network_access_enabled": {
 				Type:     pluginsdk.TypeBool,
-				Computed: true,
+				Default:  true,
+				Optional: true,
 			},
 
 			"replica_capacity": {
@@ -412,6 +413,16 @@ func resourceMysqlFlexibleServerCreate(d *pluginsdk.ResourceData, meta interface
 		parameters.Properties.SourceServerResourceId = utils.String(v.(string))
 	}
 
+	if v, ok := d.GetOk("public_network_access_enabled"); ok {
+		var publicNetworkAccess servers.EnableStatusEnum
+		if v.(bool) {
+			publicNetworkAccess = servers.EnableStatusEnumEnabled
+		} else {
+			publicNetworkAccess = servers.EnableStatusEnumDisabled
+		}
+		parameters.Properties.Network.PublicNetworkAccess = pointer.To(publicNetworkAccess)
+	}
+
 	pointInTimeUTC := d.Get("point_in_time_restore_time_in_utc").(string)
 	if pointInTimeUTC != "" {
 		v, err := time.Parse(time.RFC3339, pointInTimeUTC)
@@ -706,6 +717,19 @@ func resourceMysqlFlexibleServerUpdate(d *pluginsdk.ResourceData, meta interface
 		parameters.Tags = tags.Expand(d.Get("tags").(map[string]interface{}))
 	}
 
+	if d.HasChange("public_network_access_enabled") {
+		var publicNetworkAccess servers.EnableStatusEnum
+		if d.Get("public_network_access_enabled").(bool) {
+			publicNetworkAccess = servers.EnableStatusEnumEnabled
+		} else {
+			publicNetworkAccess = servers.EnableStatusEnumDisabled
+		}
+		if parameters.Properties.Network == nil {
+			parameters.Properties.Network = &servers.Network{}
+		}
+		parameters.Properties.Network.PublicNetworkAccess = pointer.To(publicNetworkAccess)
+	}
+
 	if err := client.UpdateThenPoll(ctx, *id, parameters); err != nil {
 		return fmt.Errorf("updating %s: %+v", *id, err)
 	}

website/docs/r/mysql_flexible_server.html.markdown

@@ -115,6 +115,8 @@ The following arguments are supported:
 
 ~> **NOTE:** The `private_dns_zone_id` is required when setting a `delegated_subnet_id`. The `azurerm_private_dns_zone` should end with suffix `.mysql.database.azure.com`.
 
+* `public_network_access_enabled` - (Optional) Is the public network access enabled? Defaults to `true`.
+
 * `replication_role` - (Optional) The replication role. Possible value is `None`.
 
 ~> **NOTE:** The `replication_role` cannot be set while creating and only can be updated from `Replica` to `None`.
@@ -205,8 +207,6 @@ In addition to the Arguments listed above - the following Attributes are exporte
 
 * `fqdn` - The fully qualified domain name of the MySQL Flexible Server.
 
-* `public_network_access_enabled` - Is the public network access enabled?
-
 * `replica_capacity` - The maximum number of replicas that a primary MySQL Flexible Server can have.
 
 ## Timeouts