fix private endpoint tests

Author: sreallymatt

internal/services/network/private_endpoint_resource_test.go

@@ -8,12 +8,12 @@ import (
 	"fmt"
 	"testing"
 
+	"github.com/hashicorp/go-azure-helpers/lang/pointer"
 	"github.com/hashicorp/go-azure-sdk/resource-manager/network/2024-05-01/privateendpoints"
 	"github.com/hashicorp/terraform-provider-azurerm/internal/acceptance"
 	"github.com/hashicorp/terraform-provider-azurerm/internal/acceptance/check"
 	"github.com/hashicorp/terraform-provider-azurerm/internal/clients"
 	"github.com/hashicorp/terraform-provider-azurerm/internal/tf/pluginsdk"
-	"github.com/hashicorp/terraform-provider-azurerm/utils"
 )
 
 type PrivateEndpointResource struct{}
@@ -69,18 +69,11 @@ func TestAccPrivateEndpoint_updateTag(t *testing.T) {
 	})
 }
 
-func TestAccPrivateEndpoint_updateNicName(t *testing.T) {
+func TestAccPrivateEndpoint_withCustomNicName(t *testing.T) {
 	data := acceptance.BuildTestData(t, "azurerm_private_endpoint", "test")
 	r := PrivateEndpointResource{}
 
 	data.ResourceTest(t, r, []acceptance.TestStep{
-		{
-			Config: r.basic(data),
-			Check: acceptance.ComposeTestCheckFunc(
-				check.That(data.ResourceName).ExistsInAzure(r),
-			),
-		},
-		data.ImportStep(),
 		{
 			Config: r.withCustomNicName(data),
 			Check: acceptance.ComposeTestCheckFunc(
@@ -89,13 +82,6 @@ func TestAccPrivateEndpoint_updateNicName(t *testing.T) {
 			),
 		},
 		data.ImportStep(),
-		{
-			Config: r.basic(data),
-			Check: acceptance.ComposeTestCheckFunc(
-				check.That(data.ResourceName).ExistsInAzure(r),
-			),
-		},
-		data.ImportStep(),
 	})
 }
 
@@ -308,7 +294,7 @@ func (t PrivateEndpointResource) Exists(ctx context.Context, clients *clients.Cl
 		return nil, fmt.Errorf("reading Private Endpoint (%s): %+v", id.String(), err)
 	}
 
-	return utils.Bool(resp.Model != nil), nil
+	return pointer.To(resp.Model != nil), nil
 }
 
 func TestAccPrivateEndpoint_multipleInstances(t *testing.T) {
@@ -771,7 +757,7 @@ resource "azurerm_private_dns_zone" "sales" {
 }
 
 resource "azurerm_private_endpoint" "test" {
-  name                = "acceptance.privatelink.%d"
+  name                = "acctest-privatelink-%d"
   location            = azurerm_resource_group.test.location
   resource_group_name = azurerm_resource_group.test.name
   subnet_id           = azurerm_subnet.endpoint.id