Merge branch 'main' of github.com:hashicorp/terraform-provider-azurerm into public-ip-basic

Author: teowa

.github/labeler-issue-triage.yml

@@ -212,6 +212,9 @@ service/maintenance:
 service/managed-apps:
   - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_managed_application((.|\n)*)###'
 
+service/managed-devops-pools:
+  - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_managed_devops_pool((.|\n)*)###'
+
 service/managed-hsm:
   - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_key_vault_managed_hardware_security_module((.|\n)*)###'
 
@@ -291,7 +294,7 @@ service/relay:
   - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_relay_((.|\n)*)###'
 
 service/resource:
-  - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_(management_group_template_deployment\W+|management_lock\W+|resource_deployment_script_azure_cli\W+|resource_deployment_script_azure_power_shell\W+|resource_group\W+|resource_group_template_deployment\W+|resource_management_private_link\W+|resource_management_private_link_association\W+|resource_provider_registration\W+|resources|subscription_template_deployment|template_spec_version|tenant_template_deployment)((.|\n)*)###'
+  - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_(management_group_template_deployment\W+|management_lock\W+|resource_deployment_script_azure_cli\W+|resource_deployment_script_azure_power_shell\W+|resource_group\W+|resource_group_template_deployment\W+|resource_management_private_link\W+|resource_management_private_link_association\W+|resource_provider_feature_registration\W+|resource_provider_registration\W+|resources|subscription_template_deployment|template_spec_version|tenant_template_deployment)((.|\n)*)###'
 
 service/search:
   - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_search_s((.|\n)*)###'
@@ -357,4 +360,4 @@ service/vmware:
   - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_(vmware_cluster\W+|vmware_express_route_authorization\W+|vmware_netapp_volume_attachment\W+|vmware_private_cloud\W+|voice_services_communications_gateway\W+|voice_services_communications_gateway_test_line\W+)((.|\n)*)###'
 
 service/workloads:
-  - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_(chaos_studio_|container_connected_registry\W+|container_registry_cache_rule\W+|container_registry_credential_set\W+|container_registry_task\W+|container_registry_task_schedule_run_now\W+|container_registry_token_password\W+|kubernetes_cluster_extension\W+|kubernetes_cluster_trusted_access_role_binding\W+|kubernetes_fleet_manager\W+|kubernetes_fleet_member\W+|kubernetes_fleet_update_run\W+|kubernetes_fleet_update_strategy\W+|kubernetes_flux_configuration\W+|kubernetes_node_pool_snapshot\W+|workloads_sap_)((.|\n)*)###'
+  - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_(chaos_studio_|container_connected_registry\W+|container_registry_cache_rule\W+|container_registry_credential_set\W+|container_registry_task\W+|container_registry_task_schedule_run_now\W+|container_registry_token_password\W+|kubernetes_cluster_deployment_safeguard\W+|kubernetes_cluster_extension\W+|kubernetes_cluster_trusted_access_role_binding\W+|kubernetes_fleet_manager\W+|kubernetes_fleet_member\W+|kubernetes_fleet_update_run\W+|kubernetes_fleet_update_strategy\W+|kubernetes_flux_configuration\W+|kubernetes_node_pool_snapshot\W+|workloads_sap_)((.|\n)*)###'

.github/labeler-pull-request-triage.yml

@@ -354,6 +354,11 @@ service/managed-apps:
   - any-glob-to-any-file:
     - internal/services/managedapplications/**/*
 
+service/managed-devops-pools:
+- changed-files:
+  - any-glob-to-any-file:
+    - internal/services/manageddevopspools/**/*
+
 service/managed-hsm:
 - changed-files:
   - any-glob-to-any-file:

.github/workflows/add-waiting-response-on-fail.yaml

@@ -3,7 +3,7 @@ name: Add waiting-response on failures
 
 on:
   workflow_run:
-    workflows: ['Check for new usages of deprecated functionality', 'GoLang Linting', 'Website Linting', 'Generation Check', 'Validate Examples', 'Unit Tests', 'Terraform Schema Linting', '32 Bit Build', 'Provider Tests', 'Vendor Dependencies Check']
+    workflows: ['Check for new usages of deprecated functionality', 'GoLang Linting', 'Website Linting', 'Generation Check', 'Validate Examples', 'Unit Tests', 'Terraform Schema Linting', 'Provider Tests', 'Vendor Dependencies Check']
     types: [completed]
 
 permissions:

.github/workflows/breaking-change-detection.yaml

@@ -27,3 +27,12 @@ jobs:
         with:
           go-version-file: ./.go-version
       - run: bash ./scripts/run-breaking-change-detection.sh
+      - name: Guidance on failure
+        if: failure()
+        run: |
+          echo "::error::Breaking Schema Changes detected."
+          echo ""
+          echo "Your changes contain breaking schema changes (e.g. removing or renaming"
+          echo "a property, changing a property type, or making an optional property required)."
+          echo "Breaking changes must be gated behind the appropriate feature flag (e.g. features.FivePointOh())."
+          echo "Please review the breaking changes guide: contributing/topics/guide-breaking-changes.md"

.github/workflows/build.yml

@@ -15,7 +15,11 @@ name: build
 #
 #   https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushbranchestagsbranches-ignoretags-ignore
 #
-on: [workflow_dispatch, push]
+on:
+  workflow_dispatch:
+  push:
+    branches-ignore:
+      - automated-changelog
 
 env:
   PKG_NAME: "terraform-provider-azurerm"
@@ -124,7 +128,7 @@ jobs:
       - set-product-version
     runs-on: custom-ubuntu-22.04-medium
     if: github.repository_owner == 'hashicorp'
-    timeout-minutes: 10
+    timeout-minutes: 30
     strategy:
       fail-fast: true
       # Verify expected Artifacts list for a workflow run.

.github/workflows/close-failing-ci-prs.yaml

@@ -0,0 +1,19 @@
+name: 'Close PRs With Failing CI'
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: '0 6 * * MON,WED,FRI'
+
+permissions:
+  issues: write
+  pull-requests: write
+  checks: read
+  statuses: read
+
+jobs:
+  close-failing-ci-prs:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - name: Process PRs with failing CI
+        run: ./scripts/close-failing-ci-prs.sh -o "${{ github.repository_owner }}" -r "${{ github.event.repository.name }}" -t "${{ secrets.GITHUB_TOKEN }}" -l

.github/workflows/comment-failure.yaml

@@ -4,6 +4,9 @@ on:
   # This file is reused, and called from other workflows
   workflow_call:
 
+permissions:
+  pull-requests: write
+
 jobs:
   comment-failure:
     runs-on: ubuntu-latest
@@ -16,9 +19,31 @@ jobs:
         with:
           result-encoding: string
           script: |
+            const workflowName = '${{ github.workflow }}';
+
+            const guidance = {
+              'Vendor Dependencies Check': 'Do not modify files in the `vendor/` directory directly. Instead, update dependencies in `go.mod` and run `go mod vendor` to sync the vendor directory. Then run `make depscheck` locally to verify.',
+              'Website Linting': 'Run `make website-lint` and `make document-validate` locally to check your documentation files under `website/` for formatting or validation issues.',
+              'Generation Check': 'Run `make generate` locally to regenerate any auto-generated code, then commit the resulting changes.',
+              'GoLang Linting': 'Run the Go linter locally with `golangci-lint run -v ./internal/...` and fix any reported issues.',
+              'Terraform Schema Linting': 'Run `make tflint` locally and fix any Terraform schema issues in your resource or data source definitions.',
+              'Unit Tests': 'Run `make test` locally to reproduce and fix the failing unit tests.',
+              'ShellCheck Scripts': 'Run `make shellcheck` locally to check shell scripts for issues and fix any warnings or errors.',
+              'Validate Examples': 'Run `make validate-examples` locally to check that your example Terraform configurations under `examples/` are valid.',
+
+            };
+
+            let body = `<b>Build failure: ${workflowName}</b>\n\nThis pull request contains a build failure in the <b>${workflowName}</b> check which needs to be addressed [here](${{ env.gha_url }}).`;
+
+            if (guidance[workflowName]) {
+              body += `\n\n<b>How to fix:</b> ${guidance[workflowName]}`;
+            }
+
+            body += `\n\nFor more information, please refer to our [Contributing Guide](https://github.com/${{ github.repository }}/blob/main/contributing/README.md).`;
+
             github.rest.issues.createComment({
-             issue_number: ${{ github.event.number }},
-             owner: context.repo.owner,
-             repo: context.repo.repo,
-             body: '<b>Build failure</b> \n\n This pull request contains a build failure which needs addressed [here](${{ env.gha_url}}) .'
-             })
+              issue_number: ${{ github.event.number }},
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              body: body
+            })

.github/workflows/depscheck.yaml

@@ -3,6 +3,7 @@ name: Vendor Dependencies Check
 
 permissions:
   contents: read
+  pull-requests: write
 
 on:
   pull_request:
@@ -22,6 +23,14 @@ jobs:
           go-version-file: ./.go-version
       - run: bash scripts/gogetcookie.sh
       - run: make depscheck
+      - name: Guidance on failure
+        if: failure()
+        run: |
+          echo "::error::Vendor Dependencies Check failed."
+          echo ""
+          echo "Do not modify files in the vendor/ directory directly."
+          echo "Instead, update dependencies in go.mod and run 'go mod tidy && go mod vendor' to sync the vendor directory."
+          echo "Then run 'make depscheck' locally to verify before pushing."
   save-artifacts-on-fail:
     needs: depscheck
     if: ${{ failure() }}

.github/workflows/gencheck.yaml

@@ -3,6 +3,7 @@ name: Generation Check
 
 permissions:
   contents: read
+  pull-requests: write
 
 on:
   pull_request:
@@ -25,6 +26,13 @@ jobs:
           go-version-file: ./.go-version
       - run: bash scripts/gogetcookie.sh
       - run: make gencheck
+      - name: Guidance on failure
+        if: failure()
+        run: |
+          echo "::error::Generation Check failed."
+          echo ""
+          echo "Run 'make generate' locally to regenerate auto-generated code, then commit the changes."
+          echo "This check ensures that generated files are up to date with their source definitions."
   save-artifacts-on-fail:
     needs: gencheck
     if: ${{ failure() }}

.github/workflows/golint.yaml

@@ -3,6 +3,7 @@ name: GoLang Linting
 
 permissions:
   contents: read
+  pull-requests: write
 
 on:
   pull_request:
@@ -28,6 +29,16 @@ jobs:
         with:
           version: 'v2.4.0'
           args: -v ./internal/...
+      - name: Guidance on failure
+        if: failure()
+        run: |
+          echo "::error::GoLang Linting failed."
+          echo ""
+          echo "Run the Go linter locally: golangci-lint run -v ./internal/..."
+          echo "Fix any reported issues before pushing. Common issues include:"
+          echo "  - Unused variables or imports"
+          echo "  - Error return values not checked"
+          echo "  - Formatting issues (run 'gofmt -w .')"
   save-artifacts-on-fail:
     needs: golint
     if: ${{ failure() }}