Skip to content

Commit 8083dab

Browse files
committed
golangci-lint: change if-else block to switch
1 parent c421e7f commit 8083dab

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

internal/tools/api-version-lint/version/parse_exceptions.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,17 +86,18 @@ func parseExceptions(yamlBytes []byte, isHistorical bool) ([]Version, error) {
8686
}
8787

8888
func validateVersionException(e versionException, isHistorical bool, validModules map[string]bool) (errors []string) {
89-
if e.Module == "" {
89+
switch {
90+
case e.Module == "":
9091
errors = append(errors, "module is required")
91-
} else if !validModules[e.Module] {
92+
case !validModules[e.Module]:
9293
validModulesStr := make([]string, 0, len(validModules))
9394
for k := range validModules {
9495
validModulesStr = append(validModulesStr, k)
9596
}
9697
errors = append(errors, fmt.Sprintf("unsupported sdk module %q\nvalid modules are: %q", e.Module, strings.Join(validModulesStr, `", "`)))
97-
} else if e.Service == "" {
98+
case e.Service == "":
9899
errors = append(errors, fmt.Sprintf("module %q: service is required", e.Module))
99-
} else if e.Version == "" {
100+
case e.Version == "":
100101
errors = append(errors, fmt.Sprintf("module %q, service %q: version is required", e.Module, e.Service))
101102
}
102103

0 commit comments

Comments
 (0)