Skip to content

Commit babe79e

Browse files
committed
address pr comoments
1 parent b2812a1 commit babe79e

File tree

5 files changed

+7
-57
lines changed

5 files changed

+7
-57
lines changed

.github/workflows/add-waiting-response-on-fail.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: Add waiting-response on failures
33

44
on:
55
workflow_run:
6-
workflows: ['Check for new usages of deprecated functionality', 'GoLang Linting', 'Website Linting', 'Generation Check', 'Validate Examples', 'Unit Tests', 'Terraform Schema Linting', '32 Bit Build', 'Provider Tests', 'Vendor Dependencies Check']
6+
workflows: ['Check for new usages of deprecated functionality', 'GoLang Linting', 'Website Linting', 'Generation Check', 'Validate Examples', 'Unit Tests', 'Terraform Schema Linting', 'Provider Tests', 'Vendor Dependencies Check']
77
types: [completed]
88

99
permissions:

.github/workflows/close-failing-ci-prs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ jobs:
1616
steps:
1717
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
1818
- name: Process PRs with failing CI
19-
run: ./scripts/close-failing-ci-prs.sh -o "${{ github.repository_owner }}" -r "${{ github.event.repository.name }}" -t "${{ secrets.GITHUB_TOKEN }}"
19+
run: ./scripts/close-failing-ci-prs.sh -o "${{ github.repository_owner }}" -r "${{ github.event.repository.name }}" -t "${{ secrets.GITHUB_TOKEN }}" -l

.github/workflows/comment-failure.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
'Unit Tests': 'Run `make test` locally to reproduce and fix the failing unit tests.',
2828
'ShellCheck Scripts': 'Run `make shellcheck` locally to check shell scripts for issues and fix any warnings or errors.',
2929
'Validate Examples': 'Run `make validate-examples` locally to check that your example Terraform configurations under `examples/` are valid.',
30-
'32 Bit Build': 'The 32-bit build is failing. Run `GOARCH=386 GOOS=linux go build ./...` locally to diagnose the issue.',
30+
3131
};
3232
3333
let body = `<b>Build failure: ${workflowName}</b>\n\nThis pull request contains a build failure in the <b>${workflowName}</b> check which needs to be addressed [here](${{ env.gha_url }}).`;

.github/workflows/thirty-two-bit.yaml

Lines changed: 0 additions & 46 deletions
This file was deleted.

scripts/close-failing-ci-prs.sh

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
set -euo pipefail
1515

16-
DRY_RUN=false
16+
DRY_RUN=true
1717
WARN_DAYS=7
1818
CLOSE_DAYS=14
1919
IGNORE_LABEL="ci-ignore-failure"
@@ -30,7 +30,6 @@ MONITORED_CHECKS=(
3030
"test" # Unit Tests + gradually-deprecated job name
3131
"preview-api-version-linter" # Preview ARM API Version Linter
3232
"shellcheck" # ShellCheck Scripts
33-
"compatibility-32bit-test" # 32 Bit Build
3433
"tflint" # Terraform Schema Linting
3534
"website-lint" # Website Linting + Validate Examples job name
3635
"provider-tests" # Provider Tests
@@ -47,14 +46,14 @@ is_monitored_check() {
4746
return 1
4847
}
4948

50-
while getopts o:r:t:d flag
49+
while getopts o:r:t:l flag
5150
do
5251
case "${flag}" in
5352
o) owner=${OPTARG};;
5453
r) repo=${OPTARG};;
5554
t) token=${OPTARG};;
56-
d) DRY_RUN=true;;
57-
*) echo "Usage: $0 -o owner -r repo [-t token] [-d]"; exit 1;;
55+
l) DRY_RUN=false;;
56+
*) echo "Usage: $0 -o owner -r repo [-t token] [-l]"; exit 1;;
5857
esac
5958
done
6059

@@ -234,9 +233,6 @@ get_check_guidance() {
234233
"Validate Examples")
235234
echo "Run \`make validate-examples\` to check that your example configurations are valid."
236235
;;
237-
compatibility-32bit-test|"32 Bit Build")
238-
echo "The 32-bit build is failing. Run \`GOARCH=386 GOOS=linux go build ./...\` locally to diagnose."
239-
;;
240236
"Preview API Version Linter")
241237
echo "Check that any API version references are not using preview versions unless explicitly required."
242238
;;

0 commit comments

Comments
 (0)