azurerm_netapp_pool - add support for cool_access_enabled (#29468)

Author: mbfrahry

internal/services/netapp/netapp_pool_data_source.go

@@ -57,6 +57,11 @@ func dataSourceNetAppPool() *pluginsdk.Resource {
 				Type:     pluginsdk.TypeString,
 				Computed: true,
 			},
+
+			"cool_access_enabled": {
+				Type:     pluginsdk.TypeBool,
+				Computed: true,
+			},
 		},
 	}
 }
@@ -83,10 +88,13 @@ func dataSourceNetAppPoolRead(d *pluginsdk.ResourceData, meta interface{}) error
 	d.Set("resource_group_name", id.ResourceGroupName)
 
 	if model := resp.Model; model != nil {
-		d.Set("location", location.NormalizeNilable(&model.Location))
-		d.Set("service_level", string(model.Properties.ServiceLevel))
-		d.Set("size_in_tb", model.Properties.Size/1099511627776)
-		d.Set("encryption_type", string(pointer.From(model.Properties.EncryptionType)))
+		d.Set("location", location.Normalize(model.Location))
+
+		props := model.Properties
+		d.Set("service_level", string(props.ServiceLevel))
+		d.Set("size_in_tb", props.Size/1099511627776)
+		d.Set("encryption_type", string(pointer.From(props.EncryptionType)))
+		d.Set("cool_access_enabled", pointer.From(props.CoolAccess))
 	}
 
 	return nil

internal/services/netapp/netapp_pool_resource.go

@@ -100,8 +100,21 @@ func resourceNetAppPool() *pluginsdk.Resource {
 				}, false),
 			},
 
+			"cool_access_enabled": {
+				Type:     pluginsdk.TypeBool,
+				Optional: true,
+				Default:  false,
+			},
+
 			"tags": commonschema.Tags(),
 		},
+
+		CustomizeDiff: pluginsdk.CustomDiffWithAll(
+			// `cool_access_enabled` cannot be disabled
+			pluginsdk.ForceNewIfChange("cool_access_enabled", func(ctx context.Context, old, new, meta interface{}) bool {
+				return old.(bool) && !new.(bool)
+			}),
+		),
 	}
 
 	return resource
@@ -138,6 +151,7 @@ func resourceNetAppPoolCreate(d *pluginsdk.ResourceData, meta interface{}) error
 			ServiceLevel:   capacitypools.ServiceLevel(d.Get("service_level").(string)),
 			Size:           sizeInBytes,
 			EncryptionType: &encryptionType,
+			CoolAccess:     pointer.To(d.Get("cool_access_enabled").(bool)),
 		},
 		Tags: tags.Expand(d.Get("tags").(map[string]interface{})),
 	}
@@ -187,6 +201,10 @@ func resourceNetAppPoolUpdate(d *pluginsdk.ResourceData, meta interface{}) error
 		update.Properties.QosType = &qosType
 	}
 
+	if d.HasChange("cool_access_enabled") {
+		update.Properties.CoolAccess = pointer.To(d.Get("cool_access_enabled").(bool))
+	}
+
 	if d.HasChange("tags") {
 		tagsRaw := d.Get("tags").(map[string]interface{})
 		update.Tags = tags.Expand(tagsRaw)
@@ -244,6 +262,7 @@ func resourceNetAppPoolRead(d *pluginsdk.ResourceData, meta interface{}) error {
 		}
 		d.Set("qos_type", qosType)
 		d.Set("encryption_type", string(pointer.From(poolProperties.EncryptionType)))
+		d.Set("cool_access_enabled", pointer.From(poolProperties.CoolAccess))
 
 		return tags.FlattenAndSet(d, model.Tags)
 	}

internal/services/netapp/netapp_pool_resource_test.go

@@ -127,6 +127,28 @@ func TestAccNetAppPool_doubleEncryption(t *testing.T) {
 	})
 }
 
+func TestAccNetAppPool_coolAccess(t *testing.T) {
+	data := acceptance.BuildTestData(t, "azurerm_netapp_pool", "test")
+	r := NetAppPoolResource{}
+
+	data.ResourceTest(t, r, []acceptance.TestStep{
+		{
+			Config: r.basic(data),
+			Check: acceptance.ComposeTestCheckFunc(
+				check.That(data.ResourceName).ExistsInAzure(r),
+			),
+		},
+		data.ImportStep(),
+		{
+			Config: r.coolAccess(data),
+			Check: acceptance.ComposeTestCheckFunc(
+				check.That(data.ResourceName).ExistsInAzure(r),
+			),
+		},
+		data.ImportStep(),
+	})
+}
+
 func (t NetAppPoolResource) Exists(ctx context.Context, clients *clients.Client, state *pluginsdk.InstanceState) (*bool, error) {
 	id, err := capacitypools.ParseCapacityPoolID(state.ID)
 	if err != nil {
@@ -314,3 +336,40 @@ resource "azurerm_netapp_pool" "test" {
 }
 `, data.RandomInteger, data.Locations.Primary, data.RandomInteger, data.RandomInteger)
 }
+
+func (NetAppPoolResource) coolAccess(data acceptance.TestData) string {
+	return fmt.Sprintf(`
+provider "azurerm" {
+  features {}
+}
+
+resource "azurerm_resource_group" "test" {
+  name     = "acctestRG-netapp-%d"
+  location = "%s"
+
+  tags = {
+    "SkipNRMSNSG" = "true"
+  }
+}
+
+resource "azurerm_netapp_account" "test" {
+  name                = "acctest-NetAppAccount-%d"
+  location            = azurerm_resource_group.test.location
+  resource_group_name = azurerm_resource_group.test.name
+}
+
+resource "azurerm_netapp_pool" "test" {
+  name                = "acctest-NetAppPool-%d"
+  account_name        = azurerm_netapp_account.test.name
+  location            = azurerm_resource_group.test.location
+  resource_group_name = azurerm_resource_group.test.name
+  service_level       = "Standard"
+  size_in_tb          = 2
+  cool_access_enabled = true
+
+  tags = {
+    "CreatedOnDate" = "2022-07-08T23:50:21Z",
+  }
+}
+`, data.RandomInteger, data.Locations.Primary, data.RandomInteger, data.RandomInteger)
+}

website/docs/d/netapp_pool.html.markdown

@@ -46,6 +46,8 @@ The following attributes are exported:
 
 * `encryption_type` - The encryption type of the pool.
 
+* `cool_access_enabled` - Whether the NetApp Pool can hold cool access enabled volumes.
+
 ---
 
 ## Timeouts

website/docs/r/netapp_pool.html.markdown

@@ -58,6 +58,10 @@ The following arguments are supported:
 
 * `encryption_type` - (Optional) The encryption type of the pool. Valid values include `Single`, and `Double`. Defaults to `Single`. Changing this forces a new resource to be created.
 
+* `cool_access_enabled` - (Optional) Whether the NetApp Pool can hold cool access enabled volumes. Defaults to `false`.
+
+~> **Note:** Disabling `cool_access_enabled` is not allowed and forces a new resource to be created.
+
 * `tags` - (Optional) A mapping of tags to assign to the resource.
 
 ---