use PUT so we can update the field upgradeable_to

Author: teowa

internal/services/redhatopenshift/redhat_openshift_cluster_resource.go

@@ -1,7 +1,7 @@
 // Copyright IBM Corp. 2014, 2025
 // SPDX-License-Identifier: MPL-2.0
 
-//go:generate go run ../../tools/generator-tests resourceidentity -resource-name redhat_openshift_cluster -service-package-name redhatopenshift -properties "name,resource_group_name" -known-values "subscription_id:data.Subscriptions.Primary"
+//go:generate go run ../../tools/generator-tests resourceidentity -resource-name redhat_openshift_cluster -service-package-name redhatopenshift -properties "name,resource_group_name" -known-values "subscription_id:data.Subscriptions.Primary" -test-expect-non-empty
 
 package redhatopenshift
 
@@ -619,42 +619,66 @@ func (r RedHatOpenShiftCluster) Update() sdk.ResourceFunc {
 				return fmt.Errorf("decoding: %+v", err)
 			}
 
-			var update openshiftclusters.OpenShiftClusterUpdate
+			existing, err := client.Get(ctx, *id)
+			if err != nil {
+				return fmt.Errorf("retrieving %s: %+v", id, err)
+			}
+			if existing.Model == nil {
+				return fmt.Errorf("retrieving %s: `model` was nil", id)
+			}
+			if existing.Model.Properties == nil {
+				return fmt.Errorf("retrieving %s: `properties` was nil", id)
+			}
+
+			parameter := *existing.Model
+
+			// These properties are read-only and populated by Azure; including them in the update request body is rejected.
+			parameter.SystemData = nil
+			parameter.Properties.ProvisioningState = nil
+			parameter.Properties.ConsoleProfile = nil
+			parameter.Properties.WorkerProfilesStatus = nil
+			if parameter.Properties.ClusterProfile != nil {
+				parameter.Properties.ClusterProfile.OidcIssuer = nil
+			}
+			if parameter.Properties.ApiserverProfile != nil {
+				parameter.Properties.ApiserverProfile.Url = nil
+				parameter.Properties.ApiserverProfile.IP = nil
+			}
+			if parameter.Properties.IngressProfiles != nil {
+				for i := range *parameter.Properties.IngressProfiles {
+					(*parameter.Properties.IngressProfiles)[i].IP = nil
+				}
+			}
+			if parameter.Properties.NetworkProfile != nil && parameter.Properties.NetworkProfile.LoadBalancerProfile != nil {
+				parameter.Properties.NetworkProfile.LoadBalancerProfile.EffectiveOutboundIPs = nil
+			}
 
 			if metadata.ResourceData.HasChange("identity") {
 				expandedIdentity, err := identity.ExpandUserAssignedMapFromModel(state.Identity)
 				if err != nil {
 					return fmt.Errorf("expanding `identity`: %+v", err)
 				}
-				update.Identity = expandedIdentity
+				parameter.Identity = expandedIdentity
 			}
 
 			if metadata.ResourceData.HasChange("service_principal") {
-				if update.Properties == nil {
-					update.Properties = &openshiftclusters.OpenShiftClusterProperties{}
-				}
-				update.Properties.ServicePrincipalProfile = expandOpenshiftServicePrincipalProfile(state.ServicePrincipal)
+				parameter.Properties.ServicePrincipalProfile = expandOpenshiftServicePrincipalProfile(state.ServicePrincipal)
 			}
 
 			if metadata.ResourceData.HasChange("platform_workload_identity_profile") {
-				if update.Properties == nil {
-					update.Properties = &openshiftclusters.OpenShiftClusterProperties{}
-				}
-				update.Properties.PlatformWorkloadIdentityProfile = expandOpenshiftPlatformWorkloadIdentityProfile(state.PlatformWorkloadIdentityProfile)
+				parameter.Properties.PlatformWorkloadIdentityProfile = expandOpenshiftPlatformWorkloadIdentityProfile(state.PlatformWorkloadIdentityProfile)
 			}
 
 			if metadata.ResourceData.HasChange("network_profile") {
-				if update.Properties == nil {
-					update.Properties = &openshiftclusters.OpenShiftClusterProperties{}
-				}
-				update.Properties.NetworkProfile = expandOpenshiftNetworkProfile(state.NetworkProfile)
+				parameter.Properties.NetworkProfile = expandOpenshiftNetworkProfile(state.NetworkProfile)
 			}
 
 			if metadata.ResourceData.HasChange("tags") {
-				update.Tags = pointer.To(state.Tags)
+				parameter.Tags = pointer.To(state.Tags)
 			}
 
-			if err := client.UpdateThenPoll(ctx, *id, update); err != nil {
+			// Platform workload identity updates require PUT so a workload identity can be updated in place.
+			if err := client.CreateOrUpdateThenPoll(ctx, *id, parameter); err != nil {
 				return fmt.Errorf("updating %s: %+v", id, err)
 			}
 

internal/services/redhatopenshift/redhat_openshift_cluster_resource_identity_gen_test.go

@@ -33,7 +33,7 @@ func TestAccRedhatOpenshiftCluster_resourceIdentity(t *testing.T) {
 				statecheck.ExpectIdentityValueMatchesStateAtPath("azurerm_redhat_openshift_cluster.test", tfjsonpath.New("resource_group_name"), tfjsonpath.New("resource_group_name")),
 			},
 		},
-		data.ImportBlockWithResourceIdentityStep(false),
-		data.ImportBlockWithIDStep(false),
+		data.ImportBlockWithResourceIdentityStep(true),
+		data.ImportBlockWithIDStep(true),
 	}, false)
 }