Merge branch 'main' into issue-28542/mssql_elastic_pool_ha_replica_count

# Conflicts:
#	internal/services/mssql/mssql_elasticpool_resource_test.go
#	website/docs/r/mssql_elasticpool.html.markdown

Author: katbyte

.github/ISSUE_TEMPLATE/Feature_Request.yml

@@ -57,4 +57,4 @@ body:
 
         Are there any other GitHub issues (open or closed) or pull requests that should be linked here? Vendor blog posts or documentation? For example:
 
-        * https://azure.microsoft.com/en-us/roadmap/virtual-network-service-endpoint-for-azure-cosmos-db/
+        * https://azure.microsoft.com/en-us/updates?id=general-availability-azure-cosmos-db-virtual-network-service-endpoint

.github/labeler-issue-triage.yml

@@ -221,12 +221,6 @@ service/management-groups:
 service/maps:
   - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_maps_((.|\n)*)###'
 
-service/mixed-reality:
-  - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_spatial_anchors_account((.|\n)*)###'
-
-service/mobile-network:
-  - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_mobile_network((.|\n)*)###'
-
 service/mongo-cluster:
   - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_mongo_cluster((.|\n)*)###'
 
@@ -291,11 +285,14 @@ service/redhatopenshift:
   - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_redhat_openshift_cluster((.|\n)*)###'
 
 service/redis:
-  - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_(redis_cache\W+|redis_cache_access_policy\W+|redis_cache_access_policy_assignment\W+|redis_enterprise_cluster\W+|redis_enterprise_database\W+|redis_firewall_rule\W+|redis_linked_server\W+|resource_deployment_script_azure_cli\W+|resource_deployment_script_azure_power_shell\W+|resource_management_private_link\W+|resource_management_private_link_association\W+|resource_provider_registration\W+)((.|\n)*)###'
+  - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_(managed_redis|redis_)((.|\n)*)###'
 
 service/relay:
   - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_relay_((.|\n)*)###'
 
+service/resource:
+  - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_(management_group_template_deployment\W+|management_lock\W+|resource_deployment_script_azure_cli\W+|resource_deployment_script_azure_power_shell\W+|resource_group\W+|resource_group_template_deployment\W+|resource_management_private_link\W+|resource_management_private_link_association\W+|resource_provider_registration\W+|resources|subscription_template_deployment|template_spec_version|tenant_template_deployment)((.|\n)*)###'
+
 service/search:
   - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_search_s((.|\n)*)###'
 
@@ -360,4 +357,4 @@ service/vmware:
   - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_(vmware_cluster\W+|vmware_express_route_authorization\W+|vmware_netapp_volume_attachment\W+|vmware_private_cloud\W+|voice_services_communications_gateway\W+|voice_services_communications_gateway_test_line\W+)((.|\n)*)###'
 
 service/workloads:
-  - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_(chaos_studio_|container_connected_registry\W+|container_registry_cache_rule\W+|container_registry_credential_set\W+|container_registry_task\W+|container_registry_task_schedule_run_now\W+|container_registry_token_password\W+|kubernetes_cluster_extension\W+|kubernetes_cluster_trusted_access_role_binding\W+|kubernetes_fleet_manager\W+|kubernetes_fleet_member\W+|kubernetes_fleet_update_run\W+|kubernetes_fleet_update_strategy\W+|kubernetes_flux_configuration\W+|kubernetes_node_pool_snapshot\W+|workloads_sap_)((.|\n)*)###'
+  - '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_(chaos_studio_|container_connected_registry\W+|container_registry_cache_rule\W+|container_registry_credential_set\W+|container_registry_task\W+|container_registry_task_schedule_run_now\W+|container_registry_token_password\W+|kubernetes_cluster_deployment_safeguard\W+|kubernetes_cluster_extension\W+|kubernetes_cluster_trusted_access_role_binding\W+|kubernetes_fleet_manager\W+|kubernetes_fleet_member\W+|kubernetes_fleet_update_run\W+|kubernetes_fleet_update_strategy\W+|kubernetes_flux_configuration\W+|kubernetes_node_pool_snapshot\W+|workloads_sap_)((.|\n)*)###'

.github/labeler-pull-request-triage.yml

@@ -369,16 +369,6 @@ service/maps:
   - any-glob-to-any-file:
     - internal/services/maps/**/*
 
-service/mixed-reality:
-- changed-files:
-  - any-glob-to-any-file:
-    - internal/services/mixedreality/**/*
-
-service/mobile-network:
-- changed-files:
-  - any-glob-to-any-file:
-    - internal/services/mobilenetwork/**/*
-
 service/mongo-cluster:
 - changed-files:
   - any-glob-to-any-file:
@@ -487,6 +477,7 @@ service/redhatopenshift:
 service/redis:
 - changed-files:
   - any-glob-to-any-file:
+    - internal/services/managedredis/**/*
     - internal/services/redis/**/*
     - internal/services/redisenterprise/**/*
 
@@ -495,6 +486,11 @@ service/relay:
   - any-glob-to-any-file:
     - internal/services/relay/**/*
 
+service/resource:
+- changed-files:
+  - any-glob-to-any-file:
+    - internal/services/resource/**/*
+
 service/search:
 - changed-files:
   - any-glob-to-any-file:

.github/workflows/add-waiting-response-on-fail.yaml

@@ -3,7 +3,7 @@ name: Add waiting-response on failures
 
 on:
   workflow_run:
-    workflows: ['Check for new usages of deprecated functionality', 'GoLang Linting', 'Website Linting', 'Generation Check', 'Validate Examples', 'Unit Tests', 'Terraform Schema Linting', '32 Bit Build', 'Provider Tests', 'Vendor Dependencies Check']
+    workflows: ['Check for new usages of deprecated functionality', 'GoLang Linting', 'Website Linting', 'Generation Check', 'Validate Examples', 'Unit Tests', 'Terraform Schema Linting', 'Provider Tests', 'Vendor Dependencies Check']
     types: [completed]
 
 permissions:

.github/workflows/breaking-change-detection.yaml

@@ -23,7 +23,16 @@ jobs:
     runs-on: custom-linux-small
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-      - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
+      - uses: actions/setup-go@40f1582b2485089dde7abd97c1529aa768e1baff # v5.6.0
         with:
           go-version-file: ./.go-version
       - run: bash ./scripts/run-breaking-change-detection.sh
+      - name: Guidance on failure
+        if: failure()
+        run: |
+          echo "::error::Breaking Schema Changes detected."
+          echo ""
+          echo "Your changes contain breaking schema changes (e.g. removing or renaming"
+          echo "a property, changing a property type, or making an optional property required)."
+          echo "Breaking changes must be gated behind the appropriate feature flag (e.g. features.FivePointOh())."
+          echo "Please review the breaking changes guide: contributing/topics/guide-breaking-changes.md"

.github/workflows/build.yml

@@ -31,7 +31,7 @@ jobs:
       go-version: ${{ steps.get-go-version.outputs.go-version }}
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-      - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
+      - uses: actions/setup-go@40f1582b2485089dde7abd97c1529aa768e1baff # v5.6.0
         with:
           go-version-file: 'go.mod'
       - name: Detect Go version
@@ -123,6 +123,8 @@ jobs:
       - get-go-version
       - set-product-version
     runs-on: custom-ubuntu-22.04-medium
+    if: github.repository_owner == 'hashicorp'
+    timeout-minutes: 30
     strategy:
       fail-fast: true
       # Verify expected Artifacts list for a workflow run.
@@ -184,4 +186,4 @@ jobs:
           echo "### What's next?" >> "$GITHUB_STEP_SUMMARY"
           echo "#### For a release branch (see \`.release/ci.hcl\`)" >> $GITHUB_STEP_SUMMARY
           echo "After this \`build\` workflow run completes succesfully, you can expect the CRT \`prepare\` workflow to begin momentarily." >> "$GITHUB_STEP_SUMMARY"
-          echo "To find the \`prepare\` workflow run, [view the checks for this commit]($github_dot_com/$owner_with_name/commits/$ref)" >> "$GITHUB_STEP_SUMMARY"
+          echo "To find the \`prepare\` workflow run, [view the checks for this commit]($github_dot_com/$owner_with_name/commits/$ref)" >> "$GITHUB_STEP_SUMMARY"

.github/workflows/close-failing-ci-prs.yaml

@@ -0,0 +1,19 @@
+name: 'Close PRs With Failing CI'
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: '0 6 * * MON,WED,FRI'
+
+permissions:
+  issues: write
+  pull-requests: write
+  checks: read
+  statuses: read
+
+jobs:
+  close-failing-ci-prs:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - name: Process PRs with failing CI
+        run: ./scripts/close-failing-ci-prs.sh -o "${{ github.repository_owner }}" -r "${{ github.event.repository.name }}" -t "${{ secrets.GITHUB_TOKEN }}" -l

.github/workflows/close-inactive-draft-prs.yaml

@@ -0,0 +1,18 @@
+name: 'Close Inactive Draft PRs'
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: '0 6 * * MON'
+
+permissions:
+  issues: write
+  pull-requests: write
+
+jobs:
+  stale-draft-prs:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - name: Process stale draft PRs
+        run: ./scripts/close-inactive-draft-prs.sh -o "${{ github.repository_owner }}" -r "${{ github.event.repository.name }}" -t "${{ secrets.GITHUB_TOKEN }}"
+

.github/workflows/comment-failure.yaml

@@ -4,23 +4,46 @@ on:
   # This file is reused, and called from other workflows
   workflow_call:
 
+permissions:
+  pull-requests: write
+
 jobs:
   comment-failure:
     runs-on: ubuntu-latest
     steps:
       - name: Get run url
-        if: failure()
         run: |
           echo "gha_url=https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}" >> $GITHUB_ENV
       - name: Send build failure comment
-        if: failure()
         uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
         with:
           result-encoding: string
           script: |
+            const workflowName = '${{ github.workflow }}';
+
+            const guidance = {
+              'Vendor Dependencies Check': 'Do not modify files in the `vendor/` directory directly. Instead, update dependencies in `go.mod` and run `go mod vendor` to sync the vendor directory. Then run `make depscheck` locally to verify.',
+              'Website Linting': 'Run `make website-lint` and `make document-validate` locally to check your documentation files under `website/` for formatting or validation issues.',
+              'Generation Check': 'Run `make generate` locally to regenerate any auto-generated code, then commit the resulting changes.',
+              'GoLang Linting': 'Run the Go linter locally with `golangci-lint run -v ./internal/...` and fix any reported issues.',
+              'Terraform Schema Linting': 'Run `make tflint` locally and fix any Terraform schema issues in your resource or data source definitions.',
+              'Unit Tests': 'Run `make test` locally to reproduce and fix the failing unit tests.',
+              'ShellCheck Scripts': 'Run `make shellcheck` locally to check shell scripts for issues and fix any warnings or errors.',
+              'Validate Examples': 'Run `make validate-examples` locally to check that your example Terraform configurations under `examples/` are valid.',
+
+            };
+
+            let body = `<b>Build failure: ${workflowName}</b>\n\nThis pull request contains a build failure in the <b>${workflowName}</b> check which needs to be addressed [here](${{ env.gha_url }}).`;
+
+            if (guidance[workflowName]) {
+              body += `\n\n<b>How to fix:</b> ${guidance[workflowName]}`;
+            }
+
+            body += `\n\nFor more information, please refer to our [Contributing Guide](https://github.com/${{ github.repository }}/blob/main/contributing/README.md).`;
+
             github.rest.issues.createComment({
-             issue_number: ${{ github.event.number }},
-             owner: context.repo.owner,
-             repo: context.repo.repo,
-             body: '<b>Build failure</b> \n\n This pull request contains a build failure which needs addressed [here](${{ env.gha_url}}) .'
-             })
+              issue_number: ${{ github.event.number }},
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              body: body
+            })

.github/workflows/depscheck.yaml

@@ -3,6 +3,7 @@ name: Vendor Dependencies Check
 
 permissions:
   contents: read
+  pull-requests: write
 
 on:
   pull_request:
@@ -17,14 +18,24 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-      - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
+      - uses: actions/setup-go@40f1582b2485089dde7abd97c1529aa768e1baff # v5.6.0
         with:
           go-version-file: ./.go-version
       - run: bash scripts/gogetcookie.sh
       - run: make depscheck
+      - name: Guidance on failure
+        if: failure()
+        run: |
+          echo "::error::Vendor Dependencies Check failed."
+          echo ""
+          echo "Do not modify files in the vendor/ directory directly."
+          echo "Instead, update dependencies in go.mod and run 'go mod tidy && go mod vendor' to sync the vendor directory."
+          echo "Then run 'make depscheck' locally to verify before pushing."
   save-artifacts-on-fail:
-    if: ${{ needs.depscheck.result }} == 'failure'
+    needs: depscheck
+    if: ${{ failure() }}
     uses: ./.github/workflows/save-artifacts.yaml
   comment-on-fail:
-    if: ${{ needs.depscheck.result }} == 'failure'
+    needs: depscheck
+    if: ${{ failure() }}
     uses: ./.github/workflows/comment-failure.yaml