make the update operations use just a timestamp vs. a datetimestamp

Author: tyler-bsc

internal/services/recoveryservices/backup_policy_vm_resource.go

@@ -114,12 +114,13 @@ func resourceBackupProtectionPolicyVMCreate(d *pluginsdk.ResourceData, meta inte
 	log.Printf("[DEBUG] Creating %s", id)
 
 	// getting this ready now because its shared between *everything*, time is... complicated for this resource
-	timeOfDay := d.Get("backup.0.time").(string)
-	dateOfDay, err := time.Parse(time.RFC3339, fmt.Sprintf("%sT%s:00Z", time.Now().Format("2006-01-02"), timeOfDay))
+	timeOfDay := fmt.Sprintf("%s:00Z", d.Get("backup.0.time").(string))
+	dateOfDay, err := time.Parse(time.RFC3339, fmt.Sprintf("%sT%s", time.Now().Format("2006-01-02"), timeOfDay))
 	if err != nil {
 		return fmt.Errorf("generating time from %q for %s: %+v", timeOfDay, id, err)
 	}
 	times := append(make([]string, 0), date.Time{Time: dateOfDay}.String())
+	formattedTimeOfDay := append(make([]string, 0), timeOfDay)
 
 	existing, err := client.Get(ctx, id)
 	if err != nil {
@@ -150,10 +151,10 @@ func resourceBackupProtectionPolicyVMCreate(d *pluginsdk.ResourceData, meta inte
 		TieringPolicy:    expandBackupProtectionPolicyVMTieringPolicy(d.Get("tiering_policy").([]interface{})),
 		InstantRPDetails: expandBackupProtectionPolicyVMResourceGroup(d),
 		RetentionPolicy: &protectionpolicies.LongTermRetentionPolicy{ // SimpleRetentionPolicy only has duration property ¯\_(ツ)_/¯
-			DailySchedule:   expandBackupProtectionPolicyVMRetentionDaily(d, times),
-			WeeklySchedule:  expandBackupProtectionPolicyVMRetentionWeekly(d, times),
-			MonthlySchedule: expandBackupProtectionPolicyVMRetentionMonthly(d, times),
-			YearlySchedule:  expandBackupProtectionPolicyVMRetentionYearly(d, times),
+			DailySchedule:   expandBackupProtectionPolicyVMRetentionDaily(d, formattedTimeOfDay),
+			WeeklySchedule:  expandBackupProtectionPolicyVMRetentionWeekly(d, formattedTimeOfDay),
+			MonthlySchedule: expandBackupProtectionPolicyVMRetentionMonthly(d, formattedTimeOfDay),
+			YearlySchedule:  expandBackupProtectionPolicyVMRetentionYearly(d, formattedTimeOfDay),
 		},
 	}
 
@@ -289,12 +290,13 @@ func resourceBackupProtectionPolicyVMUpdate(d *pluginsdk.ResourceData, meta inte
 	log.Printf("[DEBUG] Updating %s", id)
 
 	// getting this ready now because its shared between *everything*, time is... complicated for this resource
-	timeOfDay := d.Get("backup.0.time").(string)
-	dateOfDay, err := time.Parse(time.RFC3339, fmt.Sprintf("%sT%s:00Z", time.Now().Format("2006-01-02"), timeOfDay))
+	timeOfDay := fmt.Sprintf("%s:00Z", d.Get("backup.0.time").(string))
+	dateOfDay, err := time.Parse(time.RFC3339, fmt.Sprintf("%sT%s", time.Now().Format("2006-01-02"), timeOfDay))
 	if err != nil {
 		return fmt.Errorf("generating time from %q for %s: %+v", timeOfDay, id, err)
 	}
 	times := append(make([]string, 0), date.Time{Time: dateOfDay}.String())
+	formattedTimeOfDay := append(make([]string, 0), timeOfDay)
 
 	// Less than 7 daily backups is no longer supported for create/update
 	if d.HasChange("retention_daily.0.count") && (d.Get("retention_daily.0.count").(int) > 1 && d.Get("retention_daily.0.count").(int) < 7) {
@@ -360,7 +362,7 @@ func resourceBackupProtectionPolicyVMUpdate(d *pluginsdk.ResourceData, meta inte
 			properties.RetentionPolicy = &protectionpolicies.LongTermRetentionPolicy{}
 		}
 
-		retentionPolicy.DailySchedule = expandBackupProtectionPolicyVMRetentionDaily(d, times)
+		retentionPolicy.DailySchedule = expandBackupProtectionPolicyVMRetentionDaily(d, formattedTimeOfDay)
 		properties.RetentionPolicy = retentionPolicy
 	}
 
@@ -373,7 +375,7 @@ func resourceBackupProtectionPolicyVMUpdate(d *pluginsdk.ResourceData, meta inte
 			properties.RetentionPolicy = &protectionpolicies.LongTermRetentionPolicy{}
 		}
 
-		retentionPolicy.WeeklySchedule = expandBackupProtectionPolicyVMRetentionWeekly(d, times)
+		retentionPolicy.WeeklySchedule = expandBackupProtectionPolicyVMRetentionWeekly(d, formattedTimeOfDay)
 		properties.RetentionPolicy = retentionPolicy
 	}
 
@@ -386,7 +388,7 @@ func resourceBackupProtectionPolicyVMUpdate(d *pluginsdk.ResourceData, meta inte
 			properties.RetentionPolicy = &protectionpolicies.LongTermRetentionPolicy{}
 		}
 
-		retentionPolicy.MonthlySchedule = expandBackupProtectionPolicyVMRetentionMonthly(d, times)
+		retentionPolicy.MonthlySchedule = expandBackupProtectionPolicyVMRetentionMonthly(d, formattedTimeOfDay)
 		properties.RetentionPolicy = retentionPolicy
 	}
 
@@ -399,7 +401,7 @@ func resourceBackupProtectionPolicyVMUpdate(d *pluginsdk.ResourceData, meta inte
 			properties.RetentionPolicy = &protectionpolicies.LongTermRetentionPolicy{}
 		}
 
-		retentionPolicy.YearlySchedule = expandBackupProtectionPolicyVMRetentionYearly(d, times)
+		retentionPolicy.YearlySchedule = expandBackupProtectionPolicyVMRetentionYearly(d, formattedTimeOfDay)
 		properties.RetentionPolicy = retentionPolicy
 	}