containers: address local DNS review feedback

Author: hqhqhqhqhqhqhqhqhqhqhq

internal/services/containers/kubernetes_cluster_node_pool_resource.go

@@ -228,7 +228,7 @@ func resourceKubernetesClusterNodePoolSchema() map[string]*pluginsdk.Schema {
 
 		"linux_os_config": schemaNodePoolLinuxOSConfig(),
 
-		"local_dns_profile": schemaNodePoolResourceLocalDNSProfile(),
+		"local_dns_profile": schemaNodePoolLocalDNSProfile(),
 
 		"fips_enabled": {
 			Type:     pluginsdk.TypeBool,
@@ -1967,10 +1967,6 @@ func flattenAgentPoolNetworkProfileNodePublicIPTags(input *[]agentpools.IPTag) m
 	return out
 }
 
-func schemaNodePoolResourceLocalDNSProfile() *pluginsdk.Schema {
-	return schemaNodePoolLocalDNSProfile()
-}
-
 func expandAgentPoolLocalDNSProfile(input []interface{}) *agentpools.LocalDNSProfile {
 	if len(input) == 0 || input[0] == nil {
 		return nil

internal/services/containers/kubernetes_nodepool.go

@@ -282,7 +282,7 @@ func SchemaDefaultNodePool() *pluginsdk.Schema {
 						Optional: true,
 					},
 
-					"local_dns_profile": schemaDefaultNodePoolLocalDNSProfile(),
+					"local_dns_profile": schemaNodePoolLocalDNSProfile(),
 				}
 			}(),
 		},
@@ -677,10 +677,6 @@ func schemaNodePoolNetworkProfile() *pluginsdk.Schema {
 	}
 }
 
-func schemaDefaultNodePoolLocalDNSProfile() *pluginsdk.Schema {
-	return schemaNodePoolLocalDNSProfile()
-}
-
 func schemaNodePoolLocalDNSProfile() *pluginsdk.Schema {
 	return &pluginsdk.Schema{
 		Type:     pluginsdk.TypeList,
@@ -776,6 +772,9 @@ func schemaLocalDNSOverride() *pluginsdk.Schema {
 }
 
 func validateDefaultNodePoolLocalDNSProfileRawConfig(d *pluginsdk.ResourceDiff) error {
+	// The override schema uses the SDK's full-block set hash so changing settings
+	// under an existing domain still produces a diff. Raw config validation keeps
+	// the API's domain-keyed uniqueness rule without rejecting unknown domains.
 	rawConfig := d.GetRawConfig()
 	if !localDNSRawValueCanIterate(rawConfig) {
 		return nil

internal/services/containers/kubernetes_nodepool_test.go

@@ -6,6 +6,7 @@ package containers
 import (
 	"testing"
 
+	"github.com/hashicorp/go-cty/cty"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 )
 
@@ -40,3 +41,33 @@ func TestSchemaLocalDNSOverrideHashIncludesSettings(t *testing.T) {
 		t.Fatalf("expected two local DNS override hashes, got %d", localDNSOverrides.Len())
 	}
 }
+
+func TestValidateLocalDNSOverrideRawConfigSkipsUnknownDomain(t *testing.T) {
+	input := cty.ListVal([]cty.Value{
+		cty.ObjectVal(map[string]cty.Value{
+			"domain": cty.UnknownVal(cty.String),
+		}),
+		cty.ObjectVal(map[string]cty.Value{
+			"domain": cty.UnknownVal(cty.String),
+		}),
+	})
+
+	if err := validateLocalDNSOverrideRawConfig(input, "local_dns_profile.kube_dns_override"); err != nil {
+		t.Fatalf("expected unknown domains to be skipped, got %q", err)
+	}
+}
+
+func TestValidateLocalDNSOverrideRawConfigRejectsDuplicateDomain(t *testing.T) {
+	input := cty.ListVal([]cty.Value{
+		cty.ObjectVal(map[string]cty.Value{
+			"domain": cty.StringVal("example.com"),
+		}),
+		cty.ObjectVal(map[string]cty.Value{
+			"domain": cty.StringVal("example.com"),
+		}),
+	})
+
+	if err := validateLocalDNSOverrideRawConfig(input, "local_dns_profile.kube_dns_override"); err == nil {
+		t.Fatal("expected duplicate domain validation error")
+	}
+}