azurerm_signalr_service_custom_certificate - Certificate rotation

[henrikwidlund]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Allow automatic certificate rotation by setting use_specific_version to false, resulting in the certificate_version being empty/null.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevant documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
  pr-check.txt

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_signalr_service_custom_certificate - Add support for automatic certificate rotation [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #29436

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[sreallymatt]

Hi @henrikwidlund - The custom_certificate_id argument allows for versionless ID inputs, which avoids this issue as far as I can tell. Could you clarify what this is trying to solve?

We generally avoid adding arguments that are not an API property to resources.

[henrikwidlund]

Hi @henrikwidlund - The custom_certificate_id argument allows for versionless ID inputs, which avoids this issue as far as I can tell. Could you clarify what this is trying to solve?

We generally avoid adding arguments that are not an API property to resources.

Honestly I do not remember, we are setting that property. It might be that it also selected the latest certificate version from Key Vault if specific certificate version when not explicitly specified. But this was too long ago, and I think we can just close this PR.