azurerm_mssql_virtual_machine should not require LUN for SQLTempDbSettings

[agyss]

Is there an existing issue for this?

• I have searched the existing issues

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Terraform Version

1.12.2

AzureRM Provider Version

4.36.0

Affected Resource(s)/Data Source(s)

azurerm_mssql_virtual_machine

Terraform Configuration Files

resource "azurerm_mssql_virtual_machine" "sqlvm" {
  virtual_machine_id               = azurerm_windows_virtual_machine.VM.id
  sql_license_type                 = local.mergedSqlServerConfig.sqlServerLicenseType
  r_services_enabled               = local.mergedSqlServerConfig.rServicesEnabled
  sql_connectivity_port            = 1433
  sql_connectivity_type            = "PRIVATE"
  sql_connectivity_update_password = local.mergedSqlServerConfig.adminpass
  sql_connectivity_update_username = local.mergedSqlServerConfig.adminuser

  storage_configuration {
    disk_type = "NEW"
    storage_workload_type = "OLTP"
    data_settings  {
      default_file_path  = "H:\\SQLData"
      luns  = [0,1]
    }
    log_settings   {
      default_file_path  = "G:\\SQLData"
      luns  = [2,3]
    }
    temp_db_settings {
      default_file_path  = "D:\\SQLTemp"
    }
  }

Debug Output/Panic Output

 Error: Missing required argument
   
     on vm-installer/sqlserver.tf line 29, in resource "azurerm_mssql_virtual_machine" "sqlvm":
     29:     temp_db_settings {
   
   The argument "luns" is required, but no definition was found.

Expected Behaviour

The underlying arm templates support not specifying a LUN for the tempdb only - not specifying a LUN tells ARM to use the locally attached temporary ssd device.

Actual Behaviour

   Error: Missing required argument
   
     on vm-installer/sqlserver.tf line 29, in resource "azurerm_mssql_virtual_machine" "sqlvm":
     29:     temp_db_settings {
   
   The argument "luns" is required, but no definition was found.

Steps to Reproduce

terraform apply

Important Factoids

The following ARM snippet of is valid, but unable to be generated by terraform -

            "type": "Microsoft.SqlVirtualMachine/SqlVirtualMachines",
            "apiVersion": "2017-03-01-preview",
            "name": "[parameters('sqlVirtualMachineName')]",
            "location": "[parameters('sqlVirtualMachineLocation')]",
            "dependsOn": [
                "[resourceId('Microsoft.Compute/virtualMachines', parameters('sqlVirtualMachineName'))]"
            ],
            "properties": {
                "....snip....":"snipped exterranous arm",
                "StorageConfigurationSettings": {
                    "DiskConfigurationType": "NEW",
                    "StorageWorkloadType": "OLTP",
                    "SQLDataSettings": {
                        "LUNs": "[0,1]",
                        "DefaultFilePath": "F:\\data"
                    },
                    "SQLLogSettings": {
                        "LUNs": "[2,3]",
                        "DefaultFilePath": "G:\\log"
                    },
                    "SQLTempDbSettings": {
                        "DefaultFilePath": "D:\\tempDb"
                    }
                }
           }

References

Reopening of #10054 as still relevant.

[promisinganuj]

Hi @agyss , I can see that this is indeed a required property:

terraform-provider-azurerm/internal/services/mssql/helper/sql_virtual_machine_storage_settings.go

Lines 72 to 77 in a6a0028

	"luns": {
	Type: pluginsdk.TypeList,
	Required: true,
	Elem: &pluginsdk.Schema{
	Type: pluginsdk.TypeInt,
	},

Can you share the minimal setup of your "azurerm_windows_virtual_machine" resource to reproduce the scenario?

[agyss]

Please see the reference where all details are lined out. I did as @rcskosir asked in the ticket linked and reopened it as the issue remains.

[promisinganuj]

Hi @agyss , I need the "azurerm_windows_virtual_machine" configuration in addition to "azurerm_mssql_virtual_machine" so that I can reproduce it e2e.

[agyss]

resource “azurerm_windows_virtual_machine” “myvm” {
name = var.vm_name
resource_group_name = azurerm_resource_group.myrg.name
location = azurerm_resource_group.myrg.location
size = var.vm_size
admin_username = var.admin_username
admin_password = var.admin_password
network_interface_ids = [
azurerm_network_interface.nic.id,
]

os_disk {
caching = “ReadWrite”
storage_account_type = “Standard_LRS”
}

source_image_reference {
publisher = “MicrosoftSQLServer”
offer = “SQL2019-WS2019”
sku = “SQLDEV”
version = “latest”
}
}

[ZiChuanBuXiu]

Hi @agyss, after investigation we confirmed that SQL VM resource created with undefined luns field will still have [] as the value based on API response. Given this, I'd suggest use temp_db_settings.lun = [] in your Terraform config as suggested in #10054.

Thanks