Support for custom email subject in azurerm_monitor_scheduled_query_rules_alert_v2

[tahaum]

Is there an existing issue for this?

• I have searched the existing issues

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

There is a preview feature for customizing email subject in Azure log search alarms: https://learn.microsoft.com/en-us/azure/azure-monitor/alerts/alerts-customize-email-subject-how-to#sample-template

Could this be supported azurerm_monitor_scheduled_query_rules_alert_v2 under action_properties or something similar?

New or Affected Resource(s)/Data Source(s)

azurerm_monitor_scheduled_query_rules_alert_v2

Potential Terraform Configuration

References

No response

[sojournerdev]

Hey @tahaum

I went ahead and submitted a PR on your behalf.

[AshishDadhich4h2]

@tahaum when this PR will be merged and available to refer in terraform code?

[tahaum]

@tahaum when this PR will be merged and available to refer in terraform code?

Don't ask me 😅 Seems like there are 2 PRs and both are missing reviews

[sojournerdev]

I’m going to repost the PR I submitted. Hopefully, this will bump the issue.

#30561 (comment)

[toddgiguere]

There were two PRs opened for this issue which handled this property in very different ways.

1. azurerm_monitor_scheduled_query_rules_alert_v2: add support for email_subject within action block #30561 by @sojournerdev which adds a specific schema property email_subject for the user to supply, and packages it up for API internally
2. feat: add ActionProperties to monitor_scheduled_query_rule_alert_v2 #30526 by @FakieHeelflip which adds a more generic actions_properties map to the schema and allows a more free-form way to enter the property

After doing some testing with the API and solution 2 above, we have discovered that having a free-form approach will be extremely hard to validate to prevent apply-time errors when the very specific map key of "Email.Subject" (case sensitive) is not supplied correctly.

We think that solution 1 above, with a specific schema property email_subject can be controlled better by the provider to eliminate potential error conditions.

@sojournerdev I cannot repoen your PR due to the branch being deleted. If you are unable to reopen I can create a new PR myself and continue with your proposed change.

[sojournerdev]

There were two PRs opened for this issue which handled this property in very different ways.

1. azurerm_monitor_scheduled_query_rules_alert_v2: add support for email_subject within action block #30561 by @sojournerdev which adds a specific schema property email_subject for the user to supply, and packages it up for API internally
2. feat: add ActionProperties to monitor_scheduled_query_rule_alert_v2 #30526 by @FakieHeelflip which adds a more generic actions_properties map to the schema and allows a more free-form way to enter the property

After doing some testing with the API and solution 2 above, we have discovered that having a free-form approach will be extremely hard to validate to prevent apply-time errors when the very specific map key of "Email.Subject" (case sensitive) is not supplied correctly.

We think that solution 1 above, with a specific schema property email_subject can be controlled better by the provider to eliminate potential error conditions.

@sojournerdev I cannot repoen your PR due to the branch being deleted. If you are unable to reopen I can create a new PR myself and continue with your proposed change.

I can get it to you guys tonight!