Skip to content

IotOperation resource availability#30915

Closed
HanaSheto27 wants to merge 8 commits intohashicorp:mainfrom
HanaSheto27:main
Closed

IotOperation resource availability#30915
HanaSheto27 wants to merge 8 commits intohashicorp:mainfrom
HanaSheto27:main

Conversation

@HanaSheto27
Copy link
Copy Markdown

@HanaSheto27 HanaSheto27 commented Oct 20, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This addition introduces comprehensive support for Azure IoT Operations, Microsoft's unified industrial IoT platform, to the AzureRM Terraform provider. The implementation includes a complete suite of resources that enable users to deploy and manage edge-to-cloud IoT solutions through Infrastructure as Code. The core foundation begins with the azurerm_iotoperations_instance resource, which serves as the container for all IoT Operations components and requires deployment to Arc-enabled Kubernetes environments via custom locations. Built upon this foundation is the azurerm_iotoperations_broker resource, providing a scalable MQTT message broker with configurable cardinality for both backend (partitions, redundancy, workers) and frontend (replicas, workers) components. Network connectivity is handled through azurerm_iotoperations_broker_listener resources, which support multiple protocols (MQTT, WebSockets, HTTP) with enterprise-grade security features including TLS encryption, cert-manager integration for automated certificate lifecycle management, and configurable authentication and authorization policies. The platform's data processing capabilities are enabled through azurerm_iotoperations_dataflow resources that define transformation and routing workflows, supported by azurerm_iotoperations_dataflow_profile resources for performance tuning and azurerm_iotoperations_dataflow_endpoint resources for connecting to external systems like Azure Data Explorer, Storage accounts, and Event Hubs. Security and access control are managed through dedicated azurerm_iotoperations_broker_authentication and azurerm_iotoperations_broker_authorization resources, providing fine-grained control over device and application access to the MQTT broker. This comprehensive resource set enables organizations to implement complete industrial IoT scenarios with edge computing capabilities, real-time data processing, secure device communication, and seamless integration with Azure cloud services, all managed declaratively through Terraform's infrastructure-as-code approach.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevant documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #0000

AI Assistance Disclosure

  • AI Assisted - This contribution was made by, or with the assistance of, AI/LLMs

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the provider.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@HanaSheto27
Copy link
Copy Markdown
Author

Hey team, this PR follows the guideline with exception of Create and update to be separate function .The Azure SDK for this resource does not currently support PATCH or partial updates as a result, the Update method sends the full payload, just like Create. The code is structured to allow partial updates in the future if/when the SDK adds PATCH support.
This is important for Terraform's ignore_changes feature, which requires Update to only send changed fields.
For now, due to SDK limitations, all fields are sent on Update.

Copy link
Copy Markdown
Collaborator

@wuxu92 wuxu92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Thanks for raising this PR, I left some comments, could you take a look and address them and I'll take another look.

required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = "~> 3.0"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the version constraint here or version = "~> 4.xx"?

Suggested change
version = "~> 3.0"

}
provider "azurerm" {
features {}
subscription_id = "d4ccd08b-0809-446d-a8b7-7af8a90109cd"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a placeholder or variable, or just omit subscription_id field.

Suggested change
subscription_id = "d4ccd08b-0809-446d-a8b7-7af8a90109cd"

also applies to all other examples

required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = "~> 3.0"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "~> 3.0"

also applies to all other examples

Comment on lines +138 to +139
instance_name = "REPLACE_WITH_INSTANCE_NAME"
broker_name = "REPLACE_WITH_BROKER_NAME"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason we use REPLACE_WITH_XXX here? can we use a environment variable, or add a comment here about hot to setup them? the same question applies to the complete config

Comment on lines +24 to +29
ExtendedLocationName *string `tfschema:"extended_location_name"`
ExtendedLocationType *string `tfschema:"extended_location_type"`
ServiceName *string `tfschema:"service_name"`
ServiceType *string `tfschema:"service_type"`
Ports []BrokerListenerPortModel `tfschema:"ports"`
ProvisioningState *string `tfschema:"provisioning_state"`
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resource model does not use pointer types; it exclusively utilizes literal types. this also applies to all other resource model definitions.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked and tested the pointer issues reviewing the SDK, most of the optional parameters from the API request are pointers.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structs defined here is for the Terraform resource, the guideline for these structs are not pointers. so we'd change it to non-pointer type to align with the provider.

@@ -62,6 +62,7 @@ Healthcare
Hybrid Compute
IoT Central
IoT Hub
IoT Operations
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems all the documents for resources are missing, could you please add documents for them

Copy link
Copy Markdown
Collaborator

@wuxu92 wuxu92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also run the Acc Tests and share the result in the PR?

"github.com/hashicorp/go-azure-sdk/resource-manager/iotoperations/2024-11-01/dataflow"
"github.com/hashicorp/go-azure-sdk/resource-manager/iotoperations/2024-11-01/dataflowendpoint"
"github.com/hashicorp/go-azure-sdk/resource-manager/iotoperations/2024-11-01/dataflowprofile"
"github.com/hashicorp/go-azure-sdk/resource-manager/iotoperations/2024-11-01/instance"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the latest stable API version is 2025-10-01, can you please upgrade to the latest API version?

@sreallymatt
Copy link
Copy Markdown
Collaborator

closing due to lack of response

@sreallymatt sreallymatt closed this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants