azurerm_application_gateway - Deprecate authentication_certificate property#31400
azurerm_application_gateway - Deprecate authentication_certificate property#31400v-yhyeo0202 wants to merge 21 commits intohashicorp:mainfrom
azurerm_application_gateway - Deprecate authentication_certificate property#31400Conversation
…d authCertificateUpdated
…way-authcert-acctest
…perty deprecation
…way-authcert-acctest
gerrytan
left a comment
There was a problem hiding this comment.
Thanks @v-yhyeo0202 , I noticed this PR has merge conflict with main. Can you please do some investigation if we should still proceed, and resolve the conflict if we do.
| }) | ||
| } | ||
|
|
||
| func TestAccApplicationGateway_authCertificate(t *testing.T) { |
There was a problem hiding this comment.
Looks like this test has been removed in main. Can you please gather some info on the corresponding PR that got merged, and assess if we should still proceed with the changes in this PR?
There was a problem hiding this comment.
I have checked and found that the PR conflict is not related to the removal of TestAccApplicationGateway_authCertificate. For the removal of TestAccApplicationGateway_authCertificate, actually it is done by me in #31076. When I start this PR, #31076 is not merged yet. Hence, I build this PR on top of #31076 as both of them are related to deprecation of application gateway V1 SKU.
gerrytan
left a comment
There was a problem hiding this comment.
Thanks @v-yhyeo0202 . I left some review comments. It will also help if you still have the link of the failing acctest that shows this property is no longer supported for V2 SKU.
|
|
||
| * `authentication_certificate` - (Optional) One or more `authentication_certificate_backend` blocks as defined below. | ||
|
|
||
| -> **Note:** `backend_http_settings.authentication_certificate` has been deprecated in accordance with the [deprecation of Application Gateway V1](https://aka.ms/V1retirement) and will be removed in v5.0 of the AzureRM Provider. |
There was a problem hiding this comment.
Can we use this MS Learn link instead, it provides more info about authentication_cert deprecation: https://learn.microsoft.com/azure/application-gateway/ssl-overview#end-to-end-tls-with-the-v2-sku
There was a problem hiding this comment.
The link has been updated.
| ### `azurerm_application_gateway` | ||
|
|
||
| * The `backend_http_settings.authentication_certificate` property has been removed. | ||
| * The `authentication_certificate` property has been removed. |
There was a problem hiding this comment.
Minor: missing a newline underneath
There was a problem hiding this comment.
A newline is added.
| resource.Schema["backend_http_settings"].Elem.(*pluginsdk.Resource).Schema["authentication_certificate"] = &pluginsdk.Schema{ | ||
| Type: pluginsdk.TypeList, | ||
| Optional: true, | ||
| Computed: true, |
There was a problem hiding this comment.
Why do we set it computed here? It was not computed before. Same with authentication_certificate below.
There was a problem hiding this comment.
Sorry, I was confused over the practice to add Computed behaviour when renaming a property as indicated in the contributor guideline. Since the property is removed, not renamed, the Computed behaviour is removed.
Thanks Gerry for the review, the link of failing acctest has been added here and in description. |
|
Acceptance test results are listed below. The tests run are determined with terraform-terracorder. The failed tests are due to pre-existing or intermittent errors.
|
|
Latest test results. The failed test is due to intermittent error. Version 4.0 Version 5.0 |


Community Note
Description
The
authentication_certificateproperty ofazurerm_application_gatewayresource can only be used with V1 SKU. As application gateway V1 SKU is retired, the application of V1 SKU can cause the error as shown in the log below when running acceptance test. Hence,authentication_certificateis deprecated in this PR.PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
I have written new tests for my resource or datasource changes & updated any relevant documentation.(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.Testing
Acceptance test results are listed below. The tests run are determined with terraform-terracorder. The failed test is due to intermittent error.
Version 4.0

https://hashicorp.teamcity.com/buildConfiguration/TF_AzureRM_AZURERM_SERVICE_PUBLIC_NETWORK/644425?buildTab=overview
Version 5.0

https://hashicorp.teamcity.com/buildConfiguration/TF_AzureRM_AZURERM_SERVICE_PUBLIC_NETWORK/644621?buildTab=overview
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_application_gateway- deprecateauthentication_certificatepropertyThis is a (please select all that apply):
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the provider.
Note
If this PR changes meaningfully during the course of review please update the title and description as required.