azurerm_kubernetes_cluster - add advanced_network_policies property to network_profile.advanced_networking block#31506
azurerm_kubernetes_cluster - add advanced_network_policies property to network_profile.advanced_networking block#31506nddq wants to merge 1 commit intohashicorp:mainfrom
azurerm_kubernetes_cluster - add advanced_network_policies property to network_profile.advanced_networking block#31506Conversation
|
@rcskosir hello, when can I expect to get a review for this PR? Thanks! |
|
Hi @nddq , The PR is merged, you can rebase to main branch. I'm happy to take over this task if you're occupied, let me know if you need any help. |
6dfbc10 to
6f3dcab
Compare
|
@ms-henglu Thanks! I have rebased this branch onto latest main |
|
@magodo @WodansSon Any chance y'all can take a pass? |
wuxu92
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I left some comments otherwise look good!
| Default: false, | ||
| AtLeastOneOf: []string{"network_profile.0.advanced_networking.0.observability_enabled", "network_profile.0.advanced_networking.0.security_enabled"}, | ||
| }, | ||
| "advanced_network_policies": { |
There was a problem hiding this comment.
as this in nest in the advanced_networking block and only one item is allowed, we may rename it to
| "advanced_network_policies": { | |
| "policy": { |
There was a problem hiding this comment.
this is the official name for this feature in the API, so I don't think we can change it
There was a problem hiding this comment.
The field name in Terraform resource doesn't have to be the same as the API/official, we prefer to deliver a clear and easy to use schema
…ty to `advanced_networking` block This change adds support for the `advanced_network_policies` property within the `network_profile.advanced_networking` block for Azure Kubernetes Service clusters. Changes: - Add `advanced_network_policies` field with valid values `FQDN` and `L7` - Add validation to ensure `advanced_network_policies` can only be set when `security_enabled` is `true`, and that it cannot be combined with a service mesh profile in `Istio` mode - Expand/flatten maps the API's `None` value to/from the Terraform-idiomatic empty string so the field can be omitted to disable advanced network policies - Add tests for the new property and validation - Update documentation Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
This change adds support for the
advanced_network_policiesproperty within thenetwork_profile.advanced_networkingblock for Azure Kubernetes Service clusters.Changes:
advanced_network_policiesfield with valid values:FQDN,L7,Noneadvanced_network_policiescan only be set toFQDNorL7whensecurity_enabledistrueCommunity Note
Description
PR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_resource- support for thething1property [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #0000
AI Assistance Disclosure
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the provider.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Note
If this PR changes meaningfully during the course of review please update the title and description as required.