Skip to content

azurerm_automation_webhook - split‎ CreateUpdate into Create and Update#31975

Merged
katbyte merged 2 commits intomainfrom
kt/split-cu-automation-webhook
Apr 22, 2026
Merged

azurerm_automation_webhook - split‎ CreateUpdate into Create and Update#31975
katbyte merged 2 commits intomainfrom
kt/split-cu-automation-webhook

Conversation

@katbyte
Copy link
Copy Markdown
Collaborator

@katbyte katbyte commented Mar 17, 2026

No description provided.

…nd Update

Split the shared resourceAutomationWebhookCreateUpdate function into
separate resourceAutomationWebhookCreate and resourceAutomationWebhookUpdate
functions.

Create uses client.CreateOrUpdate (PUT) with existence check and URI
generation logic.

Update uses client.Update (PATCH) with HasChanges guards for the
updatable fields (enabled, run_on_worker_group, parameters). The URI
is sensitive and not returned by the API, so it is preserved from state.
@katbyte katbyte requested review from a team, WodansSon and magodo as code owners March 17, 2026 02:13
@katbyte katbyte changed the title automation: split resourceAutomationWebhookCreateUpdate into Create and Update azurerm_automation_webhook - split‎ CreateUpdate into Create and Update Mar 17, 2026
Copy link
Copy Markdown
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @katbyte I left one small query but otherwise I think this looks good.

Comment thread internal/services/automation/automation_webhook_resource.go Outdated
Copy link
Copy Markdown
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @katbyte LGTM!

@katbyte
Copy link
Copy Markdown
Collaborator Author

katbyte commented Apr 22, 2026

/test

@hc-github-team-tf-azure
Copy link
Copy Markdown
Collaborator

Build: 652948
PR: #31975

Total: 4
Passed: 4
Failed: 0

Test Details
StatusTest NameDuration
✅ PASSTestAccAutomationWebhook_requiresImport121.35s
✅ PASSTestAccAutomationWebhook_basic136.06s
✅ PASSTestAccAutomationWebhook_complete136.12s
✅ PASSTestAccAutomationWebhook_update209.00s

@katbyte katbyte merged commit ec39c7e into main Apr 22, 2026
47 checks passed
@katbyte katbyte deleted the kt/split-cu-automation-webhook branch April 22, 2026 22:05
@github-actions github-actions Bot added this to the v4.70.0 milestone Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants